Migrate Setting Account Withdraw/SignOut View from XML to Compose#686
Merged
Migrate Setting Account Withdraw/SignOut View from XML to Compose#686
Conversation
# Conflicts: # presentation/src/main/java/daily/dayo/presentation/screen/main/MainNavigator.kt # presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsNavigation.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt # presentation/src/main/java/daily/dayo/presentation/view/Button.kt # presentation/src/main/res/navigation/nav_graph.xml
# Conflicts: # presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsNavigation.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt
…drawal, create a WithdrawalReason model, and update the UI
# Conflicts: # presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the setting account withdraw/sign-out functionality from XML-based layouts to Compose UI while implementing a comprehensive withdrawal flow with dynamic content guides based on withdrawal reasons.
Key Changes
- Replaced XML-based settings and withdrawal screens with Compose implementations
- Added multi-step withdrawal process with retention strategies and server-guided content
- Implemented sign-out functionality with proper navigation and state management
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| strings.xml | Added comprehensive withdrawal and sign-out text resources with retention messaging |
| SettingsScreen.kt | Migrated to Compose with sign-out dialog and withdrawal navigation |
| WithdrawScreen.kt | New Compose implementation with multi-step flow and dynamic content |
| AccountViewModel.kt | Added withdrawal guide APIs and updated state management |
| Navigation files | Updated to support new Compose-based withdrawal flow |
| Use cases & repositories | Added new APIs for withdrawal guide content retrieval |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
presentation/src/main/java/daily/dayo/presentation/screen/account/WithdrawScreen.kt
Show resolved
Hide resolved
presentation/src/main/java/daily/dayo/presentation/screen/account/WithdrawScreen.kt
Show resolved
Hide resolved
presentation/src/main/java/daily/dayo/presentation/viewmodel/AccountViewModel.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/daily/dayo/presentation/screen/account/WithdrawScreen.kt
Show resolved
Hide resolved
presentation/src/main/java/daily/dayo/presentation/screen/account/WithdrawScreen.kt
Show resolved
Hide resolved
…ccountViewModel.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yuni-ju
approved these changes
Sep 9, 2025
Comment on lines
+564
to
+578
| FilledRoundedCornerButton( | ||
| onClick = onCancel, | ||
| label = stringResource(id = content.cancelButtonTextResId), | ||
| modifier = Modifier | ||
| .weight(1f) | ||
| .height(52.dp), | ||
| color = ButtonDefaults.buttonColors( | ||
| containerColor = PrimaryL3_F2FBF7, | ||
| contentColor = Primary_23C882 | ||
| ), | ||
| textStyle = DayoTheme.typography.b3, | ||
| radius = 16, | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.width(8.dp)) |
Member
There was a problem hiding this comment.
제가 테스트한 기기에서 버튼 글씨가 잘리는 것 같습니다.
이 부분 어떻게 처리할 지 전략을 생각해봐야 할 것 같아요
Comment on lines
+868
to
+874
| AsyncImage( | ||
| model = ImageRequest.Builder(LocalContext.current) | ||
| .data(imageData) | ||
| .crossfade(true) | ||
| .memoryCacheKey("guide_${reasonTextResId}_$index") | ||
| .diskCacheKey("guide_${reasonTextResId}_$index") | ||
| .build(), |
Member
There was a problem hiding this comment.
ByteArray 이미지 데이터에 캐싱 키 처리 해주신 것 좋습니다 👍
DongJun-H
added a commit
that referenced
this pull request
Feb 3, 2026
Migrate Setting Account Withdraw/SignOut View from XML to Compose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
참고