Skip to content

Error handling while loading types from assembly #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel15 merged 1 commit into from
Sep 1, 2013
Merged

Error handling while loading types from assembly #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/RouteJs.Mvc4/MvcRouteFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Web.Mvc;
using System.Web.Routing;
using System.Linq;
using System.Reflection;

namespace RouteJs.Mvc
{
Expand Down Expand Up @@ -61,7 +62,7 @@ private void BuildLists()
{
// Get all the controllers from all loaded assemblies
var controllers = AppDomain.CurrentDomain.GetAssemblies()
.SelectMany(assembly => assembly.GetTypes())
.SelectMany(GetTypesFromAssembly)
.Where(type => type.IsSubclassOf(typeof(Controller)))
.ToList();

Expand All @@ -81,6 +82,18 @@ private void BuildLists()
}
}
}

private IEnumerable<Type> GetTypesFromAssembly(Assembly assembly)
{
try
{
return assembly.GetTypes();
}
catch (ReflectionTypeLoadException)
{
return new Type[] { };
}
}

/// <summary>
/// Gets a mapping of namespace prefix to area name
Expand Down