Merged
Conversation
SockworkOrange
force-pushed
the
236-support-set-mysql-data-type
branch
from
be1a674 to
78e8c01
Compare
SockworkOrange
force-pushed
the
236-support-set-mysql-data-type
branch
from
95c943b to
741095f
Compare
doron050
reviewed
Aug 13, 2025
| } | ||
| """ | ||
| }, | ||
| [KnownTestType.PostgresXmlDataTypes] = new TestImpl |
Collaborator
There was a problem hiding this comment.
Add a test for invalid XML
doron050
reviewed
Aug 13, 2025
| Assert.That(actual{{Consts.UnknownRecordValuePlaceholder}}.CBytea, Is.EqualTo(expected.CBytea)); | ||
| void AssertSingularEquals(QuerySql.GetPostgresArrayTypesCntRow x, QuerySql.GetPostgresArrayTypesCntRow y) | ||
| { | ||
| Assert.That(x.Cnt, Is.EqualTo(y.Cnt)); |
Collaborator
There was a problem hiding this comment.
Add a missing assertion for type
doron050
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.