Skip to content

Comments

Revert "[Snyk] Security upgrade @arcjet/next from 1.0.0-beta.9 to 1.1.0"#46

Closed
Dargon789 wants to merge 1 commit intomainfrom
revert-44-snyk-fix-cc637803793e24e8c4c52f3a9fa523a3
Closed

Revert "[Snyk] Security upgrade @arcjet/next from 1.0.0-beta.9 to 1.1.0"#46
Dargon789 wants to merge 1 commit intomainfrom
revert-44-snyk-fix-cc637803793e24e8c4c52f3a9fa523a3

Conversation

@Dargon789
Copy link
Owner

Reverts #44

@vercel
Copy link
Contributor

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
arcjet-example Error Error Feb 7, 2026 3:04am
arcjet-example-pvhg Error Error Feb 7, 2026 3:04am

@snyk-io
Copy link
Contributor

snyk-io bot commented Feb 7, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fully reverts a previous Snyk-initiated security upgrade that had updated the @arcjet/next package and its related components to version 1.1.0. The revert restores the project's dependencies to their earlier 1.0.0-beta.9 state, which includes adjusting Node.js engine compatibility and modifying the overall dependency structure. This action aims to resolve any potential issues or incompatibilities that may have arisen from the 1.1.0 upgrade, ensuring the project returns to a stable and functional configuration.

Highlights

  • Revert of Arcjet Next.js Integration: The primary change involves reverting the @arcjet/next package and its associated @arcjet/* dependencies from version 1.1.0 back to 1.0.0-beta.9 in both package.json and package-lock.json.
  • Node.js Engine Requirement Downgrade: The minimum Node.js version requirement for several @arcjet/* packages has been reverted from >=20 to >=18, aligning with the older 1.0.0-beta.9 versions.
  • Dependency Tree Restructuring: The package-lock.json reflects significant changes in the dependency tree, with several previously nested @arcjet/* internal dependencies (e.g., @arcjet/cache, @arcjet/protocol) being removed from their nested locations and some becoming top-level entries due to resolution changes.
  • Removal of 'dev' Flag for Optional Dependencies: The dev: true flag has been removed from numerous optional dependencies within package-lock.json, indicating a change in how these dependencies are classified or managed by the package manager after the revert.
  • Introduction of New Transitive Dependencies: As a consequence of reverting to older dependency versions, undici@5.29.0 and @fastify/busboy@2.1.1 are now introduced as new top-level transitive dependencies in package-lock.json.
Changelog
  • package-lock.json
    • Reverted @arcjet/next and related @arcjet/* packages (e.g., @arcjet/analyze, @arcjet/analyze-wasm, @arcjet/duration, @arcjet/headers, @arcjet/logger, @arcjet/runtime, @arcjet/stable-hash, arcjet) from version 1.1.0 to 1.0.0-beta.9.
    • Adjusted Node.js engine requirements for several @arcjet/* packages from >=20 to >=18.
    • Removed nested dependency entries for @arcjet/cache, @arcjet/protocol, @bufbuild/protobuf, and @connectrpc/connect that were previously present under @arcjet/analyze, @arcjet/logger, @arcjet/next, and arcjet.
    • Updated @arcjet/transport's internal dependencies: @bufbuild/protobuf to 1.10.1, @connectrpc/connect to 1.6.1, @connectrpc/connect-node to 1.6.1, and @connectrpc/connect-web to 1.6.1.
    • Added top-level entries for node_modules/@connectrpc/connect-node and node_modules/@connectrpc/connect-web at version 1.6.1.
    • Removed the "dev": true flag from numerous optional dependencies.
    • Introduced new top-level transitive dependencies undici@5.29.0 and @fastify/busboy@2.1.1, which are now required by the reverted dependency tree.
  • package.json
    • Reverted the @arcjet/next dependency from 1.1.0 to 1.0.0-beta.9.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous Snyk security upgrade for the @arcjet/next package, downgrading it from version 1.1.0 to 1.0.0-beta.9. This action is highly concerning as it likely re-introduces a security vulnerability. Furthermore, it's a downgrade from a stable release to a beta version. My review includes a critical comment on package.json to highlight this risk and strongly recommend re-evaluating this change. If the newer version caused problems, those should be addressed directly instead of reverting a crucial security fix.

"@arcjet/env": "1.0.0-beta.9",
"@arcjet/ip": "1.0.0-beta.9",
"@arcjet/next": "1.1.0",
"@arcjet/next": "1.0.0-beta.9",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Reverting @arcjet/next from a stable version 1.1.0 to a beta version 1.0.0-beta.9 is a significant concern. According to the pull request title, this reverts a Snyk security upgrade, which likely re-introduces a security vulnerability. Reverting security fixes should be avoided. If the upgrade to 1.1.0 caused issues, those should be investigated and fixed to allow for the use of the secure version. If this revert is unavoidable for now, it's critical to create a follow-up task to address the underlying problem and re-apply the security upgrade as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant