fix: use char-count truncation in parse_skill_metadata to prevent panic on multi-byte UTF-8#2
Open
nxxxsooo wants to merge 1 commit intoDargonLee:mainfrom
Open
Conversation
parse_skill_metadata used byte slicing (&desc[..197]) to truncate long descriptions. This panics when byte 197 falls inside a multi-byte UTF-8 character (e.g. CJK text). Switch to chars().take(197) for safe, character-based truncation. Fixes DargonLee#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_skill_metadatapanicking when truncating descriptions containing multi-byte UTF-8 characters (CJK, emoji, etc.)&desc[..197]) withchars().take(197)for safe, character-boundary-aware truncationRoot Cause
&desc[..197]is a byte-offset slice. When byte 197 lands inside a multi-byte character, Rust panics withslice_error_fail. This affects any user with SKILL.md files containing non-ASCII descriptions longer than ~67 CJK characters.Testing
Built and tested on macOS 26.3.1 (aarch64) with ~90 skills containing Chinese/English mixed descriptions. App now launches without crashing.
Fixes #1