Do more checks before flagging a model to be lit#206
Open
hemebond wants to merge 2 commits intoDarkPlacesEngine:masterfrom
Open
Do more checks before flagging a model to be lit#206hemebond wants to merge 2 commits intoDarkPlacesEngine:masterfrom
hemebond wants to merge 2 commits intoDarkPlacesEngine:masterfrom
Conversation
… be lit via its model->lit property. Check we have lightmap data before enabling the lit property on a loadmodel.
divVerent
approved these changes
Oct 25, 2024
|
Updates? This has been approved already... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not set the RENDER_LIGHT flag on an entity if it is not flagged to be lit via its model->lit property.
Check we have lightmap data before enabling the lit property on a loadmodel.
Fixes #103