Skip to content

Conversation

@filipleple
Copy link
Member

No description provided.

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…port

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple filipleple self-assigned this Apr 15, 2025
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
UEFIExtract gets downloaded when building for laptops with ./build.sh as of
recent. Adding it to .gitignore for convenience.

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple filipleple requested review from miczyg1 and mkopec April 15, 2025 15:36
@filipleple filipleple marked this pull request as ready for review April 15, 2025 15:36
Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you introduce a new Kconfig option for EDK2 you have to bump edk2 and edk2-platforms revisions in every config. Otherwise, this new option will remain broken on the platform which do not update the edk2 and edk2-platforms. @filipleple

Accounts for the itroduction of the CONFIG_EDK2_FTDI_USB_UART_SUPPORT=y
Kconfig option

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple
Copy link
Member Author

Right, thanks, updated for all platforms

@filipleple filipleple requested a review from miczyg1 April 16, 2025 12:48
Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested a binary for NS5x TGL from CI and it seems to work as expected 👍

@mkopec mkopec merged commit 103a46e into dasharo Apr 16, 2025
55 checks passed
@mkopec mkopec deleted the ftdi-rebased branch April 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants