MTL TCSS fixes #662
Merged
MTL TCSS fixes #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes small misconfiguration, but does not fix the problem with disappearing devices in the dock in Windows |
miczyg1
force-pushed
the
mtl_dock_fixes
branch
4 times, most recently
from
2f3e898 to
58209fb
Compare
mkopec
approved these changes
May 15, 2025
Member
mkopec
left a comment
mkopec
left a comment
There was a problem hiding this comment.
Tested on NovaCustom V540TU with Wavlink UMD05 Pro Rev. E, seems to fix issue Dasharo/dasharo-issues#1316
The EnableTcssCovTypeA UPD definitions changed compared to the ADL/RPL FSP and the PCH XHCI port being mapped is not in a separate UPD anymore. Instead, it is passed in the same field as (previously boolean UINT8) EnableTcssCovTypeA. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
All TCSS XHCI ports are connected to a retimer (either TBT or USB3). These retimers already handle SBU pins and the orientation. Clear retimer bits: - for port 3 and 4 as they are not used - for port 2 as it has USB3 retimer with SBU orientation support Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
The default state of TBT force power GPIO was not consistent across variants. Assert TBT force power by default before FSP so that the initialization will be done when the retimer is active. De-assert TBT force power before handing off to the payload, so that the RTD3 logic will work in OS. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Match upstream version. The non-TBT USB2.0 port is routed the same way as for TBT port. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Mimic Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
TCSS XHCI ports that have a retimer connected should disable U1 and U2 transitions, as per Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Mimic Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Document #741494 says it is required for TCSS. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Report IRQ rotues as in reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
There was a bug which assignd IRQ for device 2.2 instead of 2.0 by using wrong macro. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Document #741494 says to set these options. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
If DP tulleing and DP_ALT monitoring is enabeld in FSP for IOM, ACPI can notify IGD about HPD assertion and wake IGD from D3 hot. Add ACPI code to detect the HPD assertions and notify IGD if needed. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Enable TCSS to notify the IGD about hot plug events and eventually wake it up from D3 hot state. Disabel PS_ON feature, as it is only available on desktops. In Intel reference code it was involved in inhibiting the power gating of certain IP blocks. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.