Skip to content

build.sh: Remove obtaining LAN ROM from regular NVC builds #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkopec merged 2 commits into from
May 16, 2025
Merged

build.sh: Remove obtaining LAN ROM from regular NVC builds #672

mkopec merged 2 commits into from
May 16, 2025

Conversation

@miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented May 16, 2025 •
edited
Loading

The build_novacsutom function is used for boards that do not require LAN ROM. Remove obtaining the release binary and UEFIExtract as it is not used in the flow. Seems like a copy-pasta error.

Tested with ./build.sh v540tu

@miczyg1
build.sh: Remove obtaining LAN ROM from regular NVC builds
410670e 
The build_novacsutom function is used for boards that do not require
LAN ROM. Remove obtaining the release binary and UEFIExtract as it is
not used in the flow. Seems like a copy-pasta error.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
@miczyg1 miczyg1 requested a review from mkopec May 16, 2025 10:11
@mkopec
Copy link
Member

mkopec commented May 16, 2025 •
edited
Loading

I get this on a fresh clone:

make: Leaving directory '/home/coreboot/coreboot/util/cbfstool'
Found file fallback/payload at 0x80, type simple elf, compressed 1757121, size 1757121
parse: not a single Volume Top File is found, the image may be corrupted
cp: cannot create regular file '3rdparty/blobs/mainboard/novacustom/mtl-h/LanRom.efi': No such file or directory

@miczyg1
Copy link
Contributor Author

miczyg1 commented May 16, 2025 •
edited
Loading

I get this on a fresh clone:

make: Leaving directory '/home/coreboot/coreboot/util/cbfstool'
Found file fallback/payload at 0x80, type simple elf, compressed 1757121, size 1757121
parse: not a single Volume Top File is found, the image may be corrupted
cp: cannot create regular file '3rdparty/blobs/mainboard/novacustom/mtl-h/LanRom.efi': No such file or directory

Aaahhh good catch.

Fixed: https://github.com/Dasharo/coreboot/compare/71baeee5d20e464e43932d5377933eaf77e162f6..a1a06b6b1863e4dd17653f564e4700bfe9e0585d

@miczyg1
build.sh: Fix builds with LAN ROM extraction
a1a06b6 
LAN ROM extarcton happened after the build, however the defconfigs
already require the blob to be present during the build. Move the
extraction before building the image.

Fix the path to 3rdparty/blobs where the LAN ROM is expected to
reside according to defconfigs. Also create the path ito ensure it
exists.

Build cbfstool and extarct the payload inside docker to avoid
problems with hsot compilation and environment.

Remove the spaces in the argument parsing for V5x0TU builds.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
@mkopec mkopec merged commit a1a06b6 into dasharo May 16, 2025
43 checks passed
@mkopec mkopec deleted the nvc_build_fix branch May 16, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkopec mkopec mkopec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miczyg1 @mkopec