QEMU_Q35 v0.2.1 shows -rc1 in BIOS and DTS

[m-iwanicki]

Component

Dasharo firmware

Device

QEMU Q35 Emulator

Dasharo version

v0.2.1

Dasharo Tools Suite version

No response

Test case ID

No response

Brief summary

Release version has -rc1 in version string

How reproducible

100%

How to reproduce

1. Start BIOS from https://github.com/Dasharo/coreboot/releases/tag/qemu_q35_v0.2.1
2. Enter BIOS menu
3. Check printed version

Expected behavior

BIOS version is Dasharo (coreboot+UEFI) v0.2.1

Actual behavior

BIOS version is Dasharo (coreboot+UEFI) v0.2.1-rc1

Screenshots

Additional context

Based on https://github.com/Dasharo/coreboot/releases/tag/qemu_q35_v0.2.1 I'd guess that it isn't RC release

Solutions you've tried

No response

[haeckle]

The CONFIG_LOCALVERSION in config.emulation_qemu_x86_q35_uefi wasn't updated. So it's still "v0.2.1-rc1" at tag qemu_q35_v0.2.1.

[pietrushnic]

@macpijan @BeataZdunczyk @philipanda what we should do with this?

[pietrushnic]

The CONFIG_LOCALVERSION in config.emulation_qemu_x86_q35_uefi wasn't updated. So it's still "v0.2.1-rc1" at tag qemu_q35_v0.2.1.

@haeckle, thanks for confirming.

[philipanda]

That's my fault. I've put the release tag on top of the RC tag without bumping up the version name first.

I'd suggest leaving the v0.2.1 as is and fixing it by releasing v0.2.2 which could integrate the virtio drivers which currently in review.

[macpijan]

That's my fault. I've put the release tag on top of the RC tag without bumping up the version name first.

Can you please add known issue to this release linking to this ticket?

[philipanda]

@macpijan Dasharo/docs#1077