Skip to content

Conversation

@lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Dec 8, 2025

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-183

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-184

These 2 packages with vulnerabilities are brought in via Terra-common-lib and Pact4s, not used by Leonardo directly. So the easiest option is to simply exclude these vulnerable packages when importing TCL and Pact.

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@lucymcnatt lucymcnatt requested a review from a team as a code owner December 8, 2025 16:07
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.12%. Comparing base (b84ac92) to head (45d0d25).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4892   +/-   ##
========================================
  Coverage    74.12%   74.12%           
========================================
  Files          131      131           
  Lines        11064    11064           
  Branches       882      882           
========================================
  Hits          8201     8201           
  Misses        2863     2863           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84ac92...45d0d25. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucymcnatt lucymcnatt requested a review from aednichols December 8, 2025 16:55
Copy link
Contributor

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very solid way of "upgrading" the library!

@lucymcnatt lucymcnatt merged commit cfaa6a7 into develop Dec 8, 2025
21 of 23 checks passed
@lucymcnatt lucymcnatt deleted the CTM-183-CTM-184-deps branch December 8, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants