Install autotools in Alpine Docker builds#101
Merged
Conversation
The rochdev/holy-node-box Alpine images lack autoconf, automake, and libtool. Rust crates that build autotools-based C libraries (e.g. libdatadog's libunwind) fail with "autoreconf: not found" during linuxmusl-* jobs. Install these tools at the start of the Docker entrypoint for Alpine containers. The glibc images already have them. Fixes DataDog/libdatadog-nodejs release build failures on musl. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
szegedi
force-pushed
the
add-autotools-to-musl-builds
branch
2 times, most recently
from
f0c48d2 to
2281418
Compare
tlhunter
approved these changes
Mar 23, 2026
tlhunter
added a commit
that referenced
this pull request
Mar 23, 2026
PR #101 unconditionally installs autoconf/automake/libtool in all Alpine Docker builds. The libtool package causes SIGSEGV in Neon Alpine tests. Pin to dfb3666 (PR #100) which includes the v3 naming fix without the autotools change. Consumers that need autotools (e.g. libdatadog-nodejs) already handle this via the `prebuild` input hook. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Merged
Member
|
Should these be baked in the base image to avoid having to re-install them every time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rochdev/holy-node-boxAlpine images lackautoconf,automake, andlibtoollibunwind) fail withautoreconf: not foundduringlinuxmusl-*jobsContext
Discovered via DataDog/libdatadog-nodejs release build failure — the
release.ymlworkflow didn't have theprebuildworkaround thatbuild.ymlhad added. Rather than requiring every consumer to add aprebuildcommand for common build tools, this makes the Alpine build environment more capable by default.Same fix was applied to the libddprof-build Docker images in DataDog/libddprof-build#149.
Test plan
linuxmusl-*jobs pass for existing projects (autotools install is a no-op if already present)prebuildworkaroundHere's CI executions with temporary pin to this branch:
https://github.com/DataDog/action-prebuildify/actions/runs/23437263463?pr=101
https://github.com/DataDog/action-prebuildify/actions/runs/23437263476?pr=101
https://github.com/DataDog/action-prebuildify/actions/runs/23437263480?pr=101
🤖 Generated with Claude Code