Skip to content

Use alpine 3.17 images to build Gyp builds only#116

Merged
szegedi merged 1 commit intomainfrom
szegedi/gyp-only-3.17
Apr 8, 2026
Merged

Use alpine 3.17 images to build Gyp builds only#116
szegedi merged 1 commit intomainfrom
szegedi/gyp-only-3.17

Conversation

@szegedi
Copy link
Copy Markdown
Contributor

@szegedi szegedi commented Apr 8, 2026

In #76 we added a pair of musl build jobs that use Alpine 3.17. These are supposed to only build per-ABI (Gyp) components for Node.js 25. Unfortunately, they also triggered for building non-Gyp components (NAPI/NAPI-RS/Neon/Rust.) We should ensure that these are still built with the base musl jobs only.

@szegedi szegedi requested a review from a team as a code owner April 8, 2026 12:29
@szegedi szegedi force-pushed the szegedi/gyp-only-3.17 branch 2 times, most recently from 92fbe27 to 77d9789 Compare April 8, 2026 13:36
…S, Neon, or Rust)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@szegedi szegedi force-pushed the szegedi/gyp-only-3.17 branch from 77d9789 to 63dac3c Compare April 8, 2026 13:44
@szegedi
Copy link
Copy Markdown
Contributor Author

szegedi commented Apr 8, 2026

Okay, we have a clean CI run. it nicely shows that the 3.17 tasks are skipped:
Screenshot 2026-04-08 at 16 01 14

I'm going to remove the temporary pinning commit now.

@szegedi szegedi requested a review from rochdev April 8, 2026 14:02
@szegedi szegedi force-pushed the szegedi/gyp-only-3.17 branch from 63dac3c to 30fabe9 Compare April 8, 2026 14:02
@szegedi szegedi merged commit 47be3ae into main Apr 8, 2026
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants