Skip to content

fix: encode binary content over rest api with base64 instead of utf-8#53

Merged
avidal merged 1 commit intomainfrom
avidal/fix-binary-push
Apr 7, 2026
Merged

fix: encode binary content over rest api with base64 instead of utf-8#53
avidal merged 1 commit intomainfrom
avidal/fix-binary-push

Conversation

@avidal
Copy link
Copy Markdown
Collaborator

@avidal avidal commented Apr 7, 2026

In the switch to v3, when the REST API was brought in, there was a bug where binary content was pushed via the REST API using utf-8 encoding instead of base64, which then triggered a downstream issue: the action release process uses commit-headless to push the built binaries into dist/, and these binaries were then treated as shell scripts.

@avidal avidal requested a review from a team as a code owner April 7, 2026 15:16
@avidal avidal force-pushed the avidal/fix-binary-push branch from aa82ed2 to 2557dfa Compare April 7, 2026 15:22
In the switch to v3, when the REST API was brought in, there was a bug
where binary content was pushed via the REST API using utf-8 encoding
instead of base64, which then triggered a downstream issue: the action
release process uses commit-headless to push the built binaries into
`dist/`, and these binaries were then treated as shell scripts.
@avidal avidal force-pushed the avidal/fix-binary-push branch from 2557dfa to 0d62a3b Compare April 7, 2026 15:27
@avidal avidal merged commit 8d3c0b4 into main Apr 7, 2026
16 of 27 checks passed
@avidal avidal deleted the avidal/fix-binary-push branch April 7, 2026 15:31
github-actions Bot added a commit that referenced this pull request Apr 7, 2026
…of utf-8 (#53)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant