Port name sampler to containerd v2 (#7)#11
Merged
Conversation
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces.
just1not2
approved these changes
May 13, 2025
EricMountain
added a commit
that referenced
this pull request
Jul 15, 2025
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
EricMountain
added a commit
that referenced
this pull request
Jul 15, 2025
* Port name sampler to containerd v2 (#7) (#11) * [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com> * feat(tracing): propagate trace context (#10) Co-authored-by: Justin Bera <justin.bera@datadoghq.com> * Test showing RuntimeHandlers in Status() are unordered Signed-off-by: Eric Mountain <eric.mountain@datadoghq.com> * CRI: Stable sort for RuntimeHandlers The runtimeHandlers list in the response to `crictl info` has unstable ordering since commit 97eb1cd (underlying switch from list to map) that was shipped in v2.1.0. On Kubernetes nodes this causes the kubelet to update node status subresources every time the order of runtime handlers changes in the status response from containerd. The lieklihood increases with the number of runtime handlers present on nodes. In some clusters this leads to every single node sending a status update every few seconds leading to excessive Kube API server load. This change enforces stable ordering on runtime handler names. Signed-off-by: Eric Mountain <eric.mountain@datadoghq.com> * Amend runtime handler test for stable order Signed-off-by: Eric Mountain <eric.mountain@datadoghq.com> --------- Signed-off-by: Eric Mountain <eric.mountain@datadoghq.com> Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com> Co-authored-by: Justin Bera <justin.bera@datadoghq.com>
EricMountain
added a commit
that referenced
this pull request
Jul 15, 2025
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
jaredledvina
pushed a commit
that referenced
this pull request
Sep 12, 2025
Update the dependency and the indirect golang.org/x/net version to align with containerd 1.7 itself, and to prevent a vulnerability being detected. This should not generally be an issue, as the API module is used by containerd 1.7 and up, which already depend on a more current version of these dependencies. full diff: containerd/ttrpc@v1.2.3...v1.2.5 Before this: govulncheck ./... Scanning your code and 251 packages across 13 dependent modules for known vulnerabilities... === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/net@v0.21.0 Fixed in: golang.org/x/net@v0.23.0 Example traces found: #1: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.ConnectionError.Error #2: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.ErrCode.String #3: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.FrameHeader.String #4: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.FrameType.String #5: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.Setting.String #6: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.SettingID.String #7: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.StreamError.Error #8: services/version/v1/version_grpc.pb.go:13:2: version.init calls status.init, which eventually calls http2.chunkWriter.Write #9: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.connError.Error #10: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.duplicatePseudoHeaderError.Error #11: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.headerFieldNameError.Error #12: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.headerFieldValueError.Error #13: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.pseudoHeaderError.Error #14: events/task_fieldpath.pb.go:85:20: events.TaskIO.Field calls fmt.Sprint, which eventually calls http2.writeData.String Your code is affected by 1 vulnerability from 1 module. This scan also found 0 vulnerabilities in packages you import and 3 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. After this: govulncheck ./... Scanning your code and 251 packages across 13 dependent modules for known vulnerabilities... === Symbol Results === No vulnerabilities found. Your code is affected by 0 vulnerabilities. This scan also found 0 vulnerabilities in packages you import and 3 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
jaredledvina
pushed a commit
that referenced
this pull request
Sep 12, 2025
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
jaredledvina
pushed a commit
that referenced
this pull request
Sep 15, 2025
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
just1not2
pushed a commit
that referenced
this pull request
Dec 3, 2025
* [tracing] Create NameSampler Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled. * [tracing] Configure otlp plugin to use NameSampler Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG`. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces. Co-authored-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple sampler that samples every span having a certain name. It's best used in conjunction with the ParentBased sampler so that the child spans are also sampled.
Allow the plugin to use the custom NameSampler if specified in the usual env vars used to specify the sampler
OTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARG. This sampler will allow to avoid emitting a lot of the noisy traces to only keep a subset of meaningful traces.