Skip to content

update workloadmeta store#23250

Merged
dd-mergequeue[bot] merged 6 commits intomainfrom
kangyi/ecs-workloadmeta-store
Mar 19, 2024
Merged

update workloadmeta store#23250
dd-mergequeue[bot] merged 6 commits intomainfrom
kangyi/ecs-workloadmeta-store

Conversation

@kangyili
Copy link
Copy Markdown
Contributor

@kangyili kangyili commented Feb 28, 2024

What does this PR do?

  • Add new method ListECSTasks
  • Update ECS task and container in comp/core/workloadmeta/types.go to have more attributes

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 28, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 0a12e80b-ad66-44b5-891c-09aa81f2fedf
Baseline: 51a2884
Comparison: ecf7c4c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.70 [-5.63, +7.04]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.70 [-5.63, +7.04]
idle memory utilization +0.21 [+0.15, +0.26]
file_tree memory utilization +0.03 [-0.07, +0.13]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
trace_agent_json ingress throughput +0.02 [-0.00, +0.04]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.06, +0.06]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.06, +0.05]
tcp_syslog_to_blackhole ingress throughput -0.03 [-0.11, +0.05]
process_agent_standard_check memory utilization -0.21 [-0.25, -0.18]
otel_to_otel_logs ingress throughput -0.38 [-0.99, +0.22]
process_agent_standard_check_with_stats memory utilization -0.66 [-0.70, -0.62]
process_agent_real_time_mode memory utilization -0.69 [-0.73, -0.64]
uds_dogstatsd_to_api_cpu % cpu utilization -1.11 [-3.94, +1.72]
pycheck_1000_100byte_tags % cpu utilization -2.19 [-7.09, +2.71]
basic_py_check % cpu utilization -2.43 [-4.85, -0.02]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@kangyili kangyili force-pushed the kangyi/ecs-workloadmeta-store branch from b01a49e to 7a7e629 Compare February 29, 2024 16:57
Base automatically changed from kangyi/ecs-v4-client to main March 12, 2024 09:22
…om:DataDog/datadog-agent into kangyi/ecs-workloadmeta-store
@kangyili kangyili marked this pull request as ready for review March 12, 2024 09:27
@kangyili kangyili requested a review from a team as a code owner March 12, 2024 09:27
Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go Outdated
Port int
Protocol string
HostPort uint16
HostIP string
Copy link
Copy Markdown
Contributor Author

@kangyili kangyili Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it's 1:1 mapping with

type Port struct {
ContainerPort uint16 `json:"ContainerPort,omitempty"`
Protocol string `json:"Protocol,omitempty"`
HostPort uint16 `json:"HostPort,omitempty"`
HostIP string `json:"HostIP,omitempty"`
}

which comes from https://github.com/aws/amazon-ecs-agent/blob/bc3cb997857126c4fe1b5fc6f5a0b192d3ef1f3b/ecs-agent/tmds/handlers/response/response.go#L26-L31

Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go Outdated
Comment thread comp/core/workloadmeta/types.go
Copy link
Copy Markdown
Contributor

@adel121 adel121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR.

Left a small comment.

@kangyili kangyili added this to the 7.53.0 milestone Mar 15, 2024
@kangyili kangyili mentioned this pull request Mar 18, 2024
10 tasks
Comment thread comp/core/workloadmeta/merge.go
Comment thread comp/core/workloadmeta/types.go Outdated
@kangyili
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 19, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue Bot merged commit 52ac8b3 into main Mar 19, 2024
@dd-mergequeue dd-mergequeue Bot deleted the kangyi/ecs-workloadmeta-store branch March 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants