update workloadmeta store#23250
Conversation
ebcade3 to
b01a49e
Compare
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 0a12e80b-ad66-44b5-891c-09aa81f2fedf Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.70 | [-5.63, +7.04] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.70 | [-5.63, +7.04] |
| ➖ | idle | memory utilization | +0.21 | [+0.15, +0.26] |
| ➖ | file_tree | memory utilization | +0.03 | [-0.07, +0.13] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.02 | [+0.01, +0.03] |
| ➖ | trace_agent_json | ingress throughput | +0.02 | [-0.00, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.06, +0.06] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.06, +0.05] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.03 | [-0.11, +0.05] |
| ➖ | process_agent_standard_check | memory utilization | -0.21 | [-0.25, -0.18] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.38 | [-0.99, +0.22] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.66 | [-0.70, -0.62] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.69 | [-0.73, -0.64] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.11 | [-3.94, +1.72] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.19 | [-7.09, +2.71] |
| ➖ | basic_py_check | % cpu utilization | -2.43 | [-4.85, -0.02] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
b01a49e to
7a7e629
Compare
…om:DataDog/datadog-agent into kangyi/ecs-workloadmeta-store
| Port int | ||
| Protocol string | ||
| HostPort uint16 | ||
| HostIP string |
There was a problem hiding this comment.
Here it's 1:1 mapping with
datadog-agent/pkg/util/ecs/metadata/v3or4/types.go
Lines 71 to 76 in 7d3819e
which comes from https://github.com/aws/amazon-ecs-agent/blob/bc3cb997857126c4fe1b5fc6f5a0b192d3ef1f3b/ecs-agent/tmds/handlers/response/response.go#L26-L31
adel121
left a comment
There was a problem hiding this comment.
Thanks for updating the PR.
Left a small comment.
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 28m) Use |
What does this PR do?
ListECSTaskscomp/core/workloadmeta/types.goto have more attributesMotivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes