cronjob status: Collect LastSuccessfulTime#23912
Conversation
79e32ef to
d5d6780
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30555146 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: c87ce19e-49fc-4bdf-b655-b9d8d15c8470 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +3.41 | [-3.23, +10.04] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +3.41 | [-3.23, +10.04] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.86 | [-0.96, +4.67] |
| ➖ | basic_py_check | % cpu utilization | +1.56 | [-0.94, +4.07] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.40 | [+1.30, +1.50] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +1.04 | [-3.88, +5.96] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.41 | [+0.38, +0.44] |
| ➖ | process_agent_standard_check | memory utilization | +0.27 | [+0.23, +0.31] |
| ➖ | file_tree | memory utilization | +0.24 | [+0.15, +0.33] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.16 | [+0.14, +0.19] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.04, +0.01] |
| ➖ | trace_agent_json | ingress throughput | -0.03 | [-0.05, +0.00] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.06 | [-0.49, +0.38] |
| ➖ | idle | memory utilization | -0.15 | [-0.18, -0.12] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
1dad437 to
4e6c8a2
Compare
fisherevans
left a comment
There was a problem hiding this comment.
approved, with one unit test nit
4e6c8a2 to
1fbe09b
Compare
1fbe09b to
14db3fb
Compare
maycmlee
left a comment
There was a problem hiding this comment.
A couple of small suggestions, but approving.
14db3fb to
bdbb115
Compare
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue Added to the queue. There are 2 builds ahead of this PR! (estimated merge in less than 28m) Use |
|
❌ MergeQueue Tests failed on this commit ea16e14 You should fix those tests and then re-add your pull request to the queue! If you need support, contact us on Slack #ci-interfaces with those details! |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 2 builds ahead! (estimated merge in less than 29m) Use |
* deps: Bump agent-payload to v5.0.109 * cronjob status: Collect LastSuccessfulTime * test: lastsuccessfultime * docs: Add release note for last successful time cron job status
What does this PR do?
https://datadoghq.atlassian.net/browse/CAP-1576
Depends on DataDog/agent-payload#295.
This pull requests collects the new cronjob status field
LastSuccessfulTime.Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes