Skip to content

cronjob status: Collect LastSuccessfulTime#23912

Merged
dd-mergequeue[bot] merged 4 commits intomainfrom
aurele.oules/cronjob-collect-lastsuccessfultime
Mar 21, 2024
Merged

cronjob status: Collect LastSuccessfulTime#23912
dd-mergequeue[bot] merged 4 commits intomainfrom
aurele.oules/cronjob-collect-lastsuccessfultime

Conversation

@aureleoules
Copy link
Copy Markdown
Member

@aureleoules aureleoules commented Mar 20, 2024

What does this PR do?

https://datadoghq.atlassian.net/browse/CAP-1576

Depends on DataDog/agent-payload#295.

This pull requests collects the new cronjob status field LastSuccessfulTime.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@aureleoules aureleoules force-pushed the aurele.oules/cronjob-collect-lastsuccessfultime branch 2 times, most recently from 79e32ef to d5d6780 Compare March 20, 2024 16:46
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 20, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30555146 --os-family=ubuntu

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 20, 2024

Regression Detector

Regression Detector Results

Run ID: c87ce19e-49fc-4bdf-b655-b9d8d15c8470
Baseline: 87fca9a
Comparison: bdbb115

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.41 [-3.23, +10.04]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.41 [-3.23, +10.04]
uds_dogstatsd_to_api_cpu % cpu utilization +1.86 [-0.96, +4.67]
basic_py_check % cpu utilization +1.56 [-0.94, +4.07]
tcp_syslog_to_blackhole ingress throughput +1.40 [+1.30, +1.50]
pycheck_1000_100byte_tags % cpu utilization +1.04 [-3.88, +5.96]
process_agent_standard_check_with_stats memory utilization +0.41 [+0.38, +0.44]
process_agent_standard_check memory utilization +0.27 [+0.23, +0.31]
file_tree memory utilization +0.24 [+0.15, +0.33]
process_agent_real_time_mode memory utilization +0.16 [+0.14, +0.19]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.04, +0.01]
trace_agent_json ingress throughput -0.03 [-0.05, +0.00]
otel_to_otel_logs ingress throughput -0.06 [-0.49, +0.38]
idle memory utilization -0.15 [-0.18, -0.12]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@aureleoules aureleoules force-pushed the aurele.oules/cronjob-collect-lastsuccessfultime branch from 1dad437 to 4e6c8a2 Compare March 21, 2024 14:02
Copy link
Copy Markdown
Member

@fisherevans fisherevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, with one unit test nit

Comment thread pkg/collector/corechecks/cluster/orchestrator/transformers/k8s/cronjob_v1_test.go Outdated
@aureleoules aureleoules force-pushed the aurele.oules/cronjob-collect-lastsuccessfultime branch from 4e6c8a2 to 1fbe09b Compare March 21, 2024 14:31
@aureleoules aureleoules force-pushed the aurele.oules/cronjob-collect-lastsuccessfultime branch from 1fbe09b to 14db3fb Compare March 21, 2024 14:32
@aureleoules aureleoules marked this pull request as ready for review March 21, 2024 14:58
@aureleoules aureleoules requested review from a team as code owners March 21, 2024 14:58
Copy link
Copy Markdown
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions, but approving.

Comment thread releasenotes/notes/add-last-successful-time-5840cb534a562598.yaml Outdated
@aureleoules aureleoules force-pushed the aurele.oules/cronjob-collect-lastsuccessfultime branch from 14db3fb to bdbb115 Compare March 21, 2024 15:18
@aureleoules
Copy link
Copy Markdown
Member Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 21, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 21, 2024

🚂 MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 21, 2024

❌ MergeQueue

Tests failed on this commit ea16e14

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

If you need support, contact us on Slack #ci-interfaces with those details!

@aureleoules
Copy link
Copy Markdown
Member Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 21, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 29m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue Bot merged commit 448cac2 into main Mar 21, 2024
@dd-mergequeue dd-mergequeue Bot deleted the aurele.oules/cronjob-collect-lastsuccessfultime branch March 21, 2024 17:41
@github-actions github-actions Bot added this to the 7.53.0 milestone Mar 21, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
* deps: Bump agent-payload to v5.0.109

* cronjob status: Collect LastSuccessfulTime

* test: lastsuccessfultime

* docs: Add release note for last successful time cron job status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants