Deploy our OCI artifact to a private registry#23931
Conversation
chouquette
added
changelog/no-changelog
There was a problem hiding this comment.
💬 Suggestion: Can we use registry.ddbuild.io/ci/remote-updates/datadog-agent:${VERSION}? That'd match the tracers
There was a problem hiding this comment.
For registry.ddbuild.io/ci/remote-updates/ no problem at all on my end.
Regarding the image name itself, I believe @vboulineau wanted to have a more descriptive name than datadog-agent.
The prefix/folder might be enough to disambiguate what kind of datadog-package though
There was a problem hiding this comment.
True, the name may change again, but it's easy to change.
|
[Fast Unit Tests Report] On pipeline 30552942 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
chouquette
force-pushed
the
chouquette/deploy_oci_to_ecr
branch
from
5766814 to
a4dbadf
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30552942 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: d32d6195-9d90-49db-ba27-3d48036700ef Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -2.01 | [-8.22, +4.20] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +2.17 | [-2.77, +7.12] |
| ➖ | basic_py_check | % cpu utilization | +1.96 | [-0.58, +4.50] |
| ➖ | file_tree | memory utilization | +0.68 | [+0.57, +0.78] |
| ➖ | idle | memory utilization | +0.09 | [+0.05, +0.13] |
| ➖ | trace_agent_json | ingress throughput | +0.04 | [+0.01, +0.07] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.19, +0.22] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.01] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.00 | [-0.47, +0.47] |
| ➖ | process_agent_standard_check | memory utilization | -0.00 | [-0.05, +0.05] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.19 | [-0.23, -0.14] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.19 | [-2.95, +2.56] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.70 | [-0.75, -0.66] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.21 | [-1.30, -1.13] |
| ➖ | file_to_blackhole | % cpu utilization | -2.01 | [-8.22, +4.20] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
this way we won't need to fiddle with the version on the release management side, we can just use it as is
chouquette
force-pushed
the
chouquette/deploy_oci_to_ecr
branch
from
a4dbadf to
42ee9e0
Compare
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
amenasria
left a comment
amenasria
left a comment
There was a problem hiding this comment.
LGTM for Agent CI Exp owned file !
|
🚂 MergeQueue Added to the queue. There are 2 builds ahead of this PR! (estimated merge in less than 28m) Use |
* deploy oci image to an internal registry * start publishing the actual pipeline artifact * update image name * use the same version pattern as other packages this way we won't need to fiddle with the version on the release management side, we can just use it as is
4 participants
What does this PR do?
This PR starts deploying our OCI artifacts to an internal registry.
Motivation
Additional Notes
This is probably a bit too
datadog-agentcentric and should be reworked to have a base job that handles multiple flavors, but we'll see about that when we get therePossible Drawbacks / Trade-offs
Describe how to test/QA your changes