[clusteragent/admission/sidecar] Set ShareProcessNamespace=true on EKS Fargate#23963
Conversation
983d1c4 to
7dca845
Compare
|
[Fast Unit Tests Report] On pipeline 30550182 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
maycmlee
left a comment
There was a problem hiding this comment.
Just a small suggestion, but approving.
338fbff to
6afa3e2
Compare
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30550182 --os-family=ubuntu |
|
🚂 MergeQueue Added to the queue. There are 4 builds ahead of this PR! (estimated merge in less than 28m) Use |
Regression DetectorRegression Detector ResultsRun ID: 77a6195c-cb38-43f6-bee5-f2a61aa9ca84 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.96 | [-7.31, +5.39] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.88 | [+0.78, +0.97] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.79 | [-1.96, +3.54] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.33 | [-4.55, +5.21] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.11 | [+0.08, +0.15] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.30, +0.52] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.04, +0.05] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.01, +0.01] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
| ➖ | idle | memory utilization | -0.00 | [-0.05, +0.04] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] |
| ➖ | process_agent_standard_check | memory utilization | -0.16 | [-0.21, -0.12] |
| ➖ | file_tree | memory utilization | -0.17 | [-0.27, -0.08] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.32 | [-0.37, -0.28] |
| ➖ | file_to_blackhole | % cpu utilization | -0.96 | [-7.31, +5.39] |
| ➖ | basic_py_check | % cpu utilization | -1.91 | [-4.35, +0.53] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…S Fargate (#23963) * [clusteragent/admission/sidecar] Set ShareProcessNamespace=true on EKS Fargate * Add release note
What does this PR do?
Sets ShareProcessNamespace=true in the sidecar admission controller webhook when deploying on EKS Fargate.
This is needed by the process collection feature.
Describe how to test/QA your changes
Deploy the Agent on EKS Fargate. You need to enable the admission controller with sidecar injection configured to enable process collection via sidecar profiles. Here's the helm chart that I used:
Now deploy something on the Fargate namespace. The only important part is to set the labels used by the admission controller correctly. Also, make sure that
shareProcessNamespaceis not set (it will be injected automatically). Here's an example deployment that you can use:Remember to create the needed RBACs for Fargate as described here: https://docs.datadoghq.com/integrations/eks_fargate/#aws-eks-fargate-rbac
Now check that process collection works as expected. In the Datadog app you should be able to see the processes both for the agent sidecar that was automatically injected and also for your container.