Skip to content

fix pod manifest#24055

Merged
dd-mergequeue[bot] merged 1 commit intomainfrom
kangyi/fix-pod-manifest
Mar 25, 2024
Merged

fix pod manifest#24055
dd-mergequeue[bot] merged 1 commit intomainfrom
kangyi/fix-pod-manifest

Conversation

@kangyili
Copy link
Copy Markdown
Contributor

What does this PR do?

Fix a bug introduced by #23823

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@kangyili kangyili requested a review from a team as a code owner March 25, 2024 10:39
@kangyili kangyili added this to the 7.53.0 milestone Mar 25, 2024
@kangyili kangyili added the changelog/no-changelog No changelog entry needed label Mar 25, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 25, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30719876 --os-family=ubuntu

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 25, 2024

Regression Detector

Regression Detector Results

Run ID: bcc76873-e5ef-4afc-9598-d990ce20d901
Baseline: 5af707e
Comparison: 0280120

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.23 [-6.55, +6.09]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.50 [+1.38, +1.62]
pycheck_1000_100byte_tags % cpu utilization +1.09 [-3.83, +6.00]
otel_to_otel_logs ingress throughput +0.25 [-0.16, +0.66]
process_agent_standard_check_with_stats memory utilization +0.06 [+0.03, +0.09]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01]
trace_agent_json ingress throughput -0.02 [-0.05, +0.01]
idle memory utilization -0.04 [-0.08, +0.01]
trace_agent_msgpack ingress throughput -0.04 [-0.05, -0.03]
file_to_blackhole % cpu utilization -0.23 [-6.55, +6.09]
uds_dogstatsd_to_api_cpu % cpu utilization -0.28 [-3.06, +2.49]
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.45, -0.29]
process_agent_standard_check memory utilization -0.46 [-0.50, -0.42]
basic_py_check % cpu utilization -0.76 [-3.29, +1.77]
process_agent_real_time_mode memory utilization -0.93 [-0.97, -0.89]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@kangyili
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 25, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 29m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue Bot merged commit b74f8f6 into main Mar 25, 2024
@dd-mergequeue dd-mergequeue Bot deleted the kangyi/fix-pod-manifest branch March 25, 2024 13:25
@kangyili kangyili mentioned this pull request Mar 28, 2024
misteriaud pushed a commit that referenced this pull request Apr 2, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants