fix pod manifest#24055
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30719876 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: bcc76873-e5ef-4afc-9598-d990ce20d901 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.23 | [-6.55, +6.09] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +1.50 | [+1.38, +1.62] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +1.09 | [-3.83, +6.00] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.25 | [-0.16, +0.66] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.06 | [+0.03, +0.09] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.02, +0.01] |
| ➖ | trace_agent_json | ingress throughput | -0.02 | [-0.05, +0.01] |
| ➖ | idle | memory utilization | -0.04 | [-0.08, +0.01] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.04 | [-0.05, -0.03] |
| ➖ | file_to_blackhole | % cpu utilization | -0.23 | [-6.55, +6.09] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.28 | [-3.06, +2.49] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.37 | [-0.45, -0.29] |
| ➖ | process_agent_standard_check | memory utilization | -0.46 | [-0.50, -0.42] |
| ➖ | basic_py_check | % cpu utilization | -0.76 | [-3.29, +1.77] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.93 | [-0.97, -0.89] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 29m) Use |
What does this PR do?
Fix a bug introduced by #23823
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes