Closed
Conversation
zippolyte
force-pushed
the
hippo/k8s_hostname
branch
from
178da70 to
6a37463
Compare
zippolyte
force-pushed
the
hippo/k8s_hostname
branch
from
6a37463 to
572b3f7
Compare
xvello
suggested changes
Jun 8, 2017
Contributor
There was a problem hiding this comment.
Including the kubernetes client makes the dogstats binary size shoot up from 11MB to 31MB, which is above our goal.
Your util/k8s code looks good to me but should not be linked into dogstatsd. We should stick with the downwards API to get the hostname. We just need to add the following to the pod spec:
env:
- name: DD_HOSTNAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
For more information: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/
Could you please instead submit your util/k8s code in a "intial k8s util implementation" PR?
Cheers
Contributor
Author
|
Done #285 |
s-alad
pushed a commit
that referenced
this pull request
Jan 6, 2026
…283) Bumps [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2) from 1.41.3 to 1.41.4. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/sts/v1.41.3...service/sts/v1.41.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-version: 1.41.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the function GetNodeInfo in util/k8s and use it to fetch the hostname when running on kubernetes