Skip to content

[metadata] Use slimmer k8s library for metadata.#291

Merged
conorbranagan merged 1 commit intomasterfrom
conor/k8-bloat
Jun 12, 2017
Merged

[metadata] Use slimmer k8s library for metadata.#291
conorbranagan merged 1 commit intomasterfrom
conor/k8-bloat

Conversation

@conorbranagan
Copy link
Copy Markdown
Contributor

What does this PR do?

Update the k8s metadata provider to use a different client library.

Confirmed to work with the process agent.

Motivation

Based on feedback in #285 we can use a smaller library that pulls in significantly fewer dependencies.

Based on feedback in #285
we can use a smaller library that pulls in significantly fewer
dependencies. The only trade-off is that we need to use getters in
function calls to avoid pointers everywhere because this is using older
style protobuf generated code.
@conorbranagan conorbranagan requested a review from hkaj June 12, 2017 14:10
Copy link
Copy Markdown
Member

@hkaj hkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@conorbranagan conorbranagan merged commit c3f293e into master Jun 12, 2017
@conorbranagan conorbranagan deleted the conor/k8-bloat branch June 12, 2017 16:29
s-alad pushed a commit that referenced this pull request Jan 6, 2026
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.32.3 to 1.32.5.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@v1.32.3...v1.32.5)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.32.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants