[py] Support yet another AgentCheck.__init__ pattern#298
Merged
Conversation
This time when `instances` is the only argument passed in `kwargs`. This pattern is quite common in the existing checks (since it's the signature of the agent5's `AgentCheck.__init__`), so it makes sense to support it. Added a test case, and assertions in the python test code.
masci
approved these changes
Jun 15, 2017
s-alad
added a commit
that referenced
this pull request
Jan 6, 2026
* add configurable max file read size limit to prevent OOM * reuse DefaultMaxFileReadSize & add tests for yaml and json * reduce test complexity * wording * wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports yet another
AgentCheck.__init__pattern, this time wheninstancesis the only argument passed inkwargs.Motivation
This pattern is quite common in the existing checks (since it's the
signature of the agent5's
AgentCheck.__init__), so it makes senseto support it.
Additional Notes
Added a test case, and assertions in the python test code.