[jmx][auto-discovery] adds jmx support for auto_discovery#301
Merged
[jmx][auto-discovery] adds jmx support for auto_discovery#301
Conversation
truthbk
changed the title
truthbk
commented
Jun 15, 2017
Member
Author
There was a problem hiding this comment.
I think we can remove this, I added this before finding the USE_SYSTEM_PY option, then forgot about it.
Contributor
There was a problem hiding this comment.
ok for me, I'd like to rethink the entire USE_SYSTEM_PY thing so the less thing we have around, the better
masci
suggested changes
Jun 15, 2017
Contributor
masci
left a comment
masci
left a comment
There was a problem hiding this comment.
A couple of nits otherwise 👍
Contributor
There was a problem hiding this comment.
can we add a very simple unit test for this?
Contributor
There was a problem hiding this comment.
I'd rename this module to jmxloader.go or loaders.go so we can accommodate more loaders in the same package if needed
[jmxfetch] bumping jmxfetch to 0.14.0. [pipe][windows] fixing compilation issues. [jmx] try to instantiate loader, if we fail to create pipe - skip. [py] skip python if we cant load python loader. [jmx][auto-discovery] implementing whitelist for specific jmxfetch checks. [jmx][auto-discovery] fix output YAML indentation. [config] include String() method. [auto-discovery] separator includes cr. [auto-discovery] renaming some more vars.
masci
approved these changes
Jun 15, 2017
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for
auto-discoveryofjmxfetchand, more specifically, relay the respective configuration to JMX via the current established mechanism - named pipes.I have also snuck in a fix to the SNMP check. I will probably get it out and into its own PR, but I have to work some git magic because I already partially squashed this😅 SNMP stuff moved to its own PR hereMotivation
Necessary feature for agent6 and
auto-discovery.Additional Notes
When we get the bandwidth, I would much rather have this implemented with gRPC if the overhead is acceptable (in terms of binary size, etc).