Skip to content

Cleaned up dogstatsd rake commands#306

Merged
masci merged 2 commits intomasterfrom
massi/rake-dsd
Jun 15, 2017
Merged

Cleaned up dogstatsd rake commands#306
masci merged 2 commits intomasterfrom
massi/rake-dsd

Conversation

@masci
Copy link
Copy Markdown
Contributor

@masci masci commented Jun 15, 2017

What does this PR do?

$ rake -T
[...]
rake dogstatsd:build             # Build Dogstatsd [race=false|incremental=false|static=false]
rake dogstatsd:omnibus           # Build omnibus installer
rake dogstatsd:run               # Run Dogstatsd
rake dogstatsd:size_test         # Run Dogstatsd size test [skip_rebuild=false]
rake dogstatsd:system_test       # Run Dogstatsd system tests [skip_rebuild=false]

xvello
xvello suggested changes Jun 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, just one issue

Comment thread rake/dogstatsd.rb
else
if ENV['skip_rebuild'] != "true" then
puts "Building DogStatsD"
Rake::Task["dogstatsd:build"].invoke
Copy link
Copy Markdown
Contributor

@xvello xvello Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size test is to be run on the static binary, should we specify: ENV['static'] = 'true'?

Copy link
Copy Markdown
Contributor Author

@masci masci Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

xvello
xvello approved these changes Jun 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masci masci merged commit fbe7fbc into master Jun 15, 2017
@masci masci deleted the massi/rake-dsd branch June 15, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xvello xvello xvello approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dev/tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masci @xvello