Conversation
olivielpeau
approved these changes
Jun 15, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Added one question, but overall this is great! 🚀
| pyval = python.PyBool_FromLong(0) | ||
| } | ||
| default: | ||
| log.Warnf("Could not convert type %s to python", reflect.TypeOf(vi)) |
Member
There was a problem hiding this comment.
this log line was definitely too verbose. That said are there cases where we should still detect and log that we're "missing" a type?
Member
There was a problem hiding this comment.
we may want to keep this one in Debug mode. It could be useful in the flare I guess.
Contributor
Author
There was a problem hiding this comment.
Not sure, the walker does trial and error at some point and the error is expected. Even if in debug, it would flood the logs (it already does, see what happens when parsing go_expvar.yaml), at the moment not having this output is more useful, we can reconsider in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the logging output a little bit more useful
Motivation
A lot of noise was going on