Conversation
gmmeyer
left a comment
gmmeyer
left a comment
There was a problem hiding this comment.
two questions but lgtm otherwise
| api_key: | ||
|
|
||
| # If you need a proxy to connect to the Internet, provide it here (default: disabled) | ||
| # proxy: http://user:password@host:port |
There was a problem hiding this comment.
My bad, blindly removed anything didn't have a SetDefault
| # proxy: http://user:password@host:port | ||
|
|
||
| # If you run the agent behind haproxy, you might want to set this to yes | ||
| # skip_ssl_validation: no |
There was a problem hiding this comment.
(agreed, these 2 options are supported, I don't think we should remove them from here)
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
This is great! ⭐️
Just a nit, but feel free to merge
| # additional_checksd: | ||
|
|
||
| # The path where the IPC api listens | ||
| # cmd_sock: |
There was a problem hiding this comment.
nit: for the 3 options above, it'd be good to document the default value (it might depend on the OS, in which case we can write a general description of the default, for example for additional_checksd: By default, uses the checks.d folder located in the agent configuration folder)
| # proxy: http://user:password@host:port | ||
|
|
||
| # If you run the agent behind haproxy, you might want to set this to yes | ||
| # skip_ssl_validation: no |
There was a problem hiding this comment.
(agreed, these 2 options are supported, I don't think we should remove them from here)
| # hostname: mymachine.mydomain | ||
|
|
||
| # The path containing check configuration files | ||
| # By default, uses the conf.d folder located in the agent installation folder. |
There was a problem hiding this comment.
agent configuration folder instead no? (same for option below)
3 participants
What does this PR do?
Consolidates the use of
SetDefaultfor any configuration setting.Motivation
Part of the defaults were set within packages, part in the common
configpackage. Let's put them all in the same place so it's less error prone.