Remove device_name/DeviceName specificity#314
Merged
olivielpeau merged 3 commits intomasterfrom Jun 19, 2017
Merged
Conversation
Should be replaced by a "standard" `device:` tag. This change shouldn't make a difference in the backend, I'll make sure of that though. * `AgentCheck` supports `device_name` as a parameter to the metric submission methods for backwards-compatibility, but we should stop supporting it at some point. * Remove all traces of `DeviceName` field in aggregator
hush-hush
requested changes
Jun 19, 2017
Member
hush-hush
left a comment
hush-hush
left a comment
There was a problem hiding this comment.
Could you also remove the DeviceName from sketch_series.go and in serializer_test.go function: TestMarshalJSONSketchSeries ?
Except that it LGTM.
Addresses PR review
Member
Author
|
Thanks @hush-hush, I had missed that. I've addressed your comment 👍 |
hush-hush
approved these changes
Jun 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
device_nameas any other tag instead of treating it as a specific fieldAgentChecksupport thedevice_nameparameter on metric submission methods, but log a deprecation warningMotivation
device_nameAdditional Notes
I can queue some work to remove all uses of
device_namefrom ourintegrations-corechecks, I can do that once we're 100% sure that this change won't make the backend create duplicate contexts.