Conversation
olivielpeau
approved these changes
Jun 28, 2017
| @@ -113,6 +113,7 @@ | |||
| end | |||
|
|
|||
| if redhat? | |||
Member
There was a problem hiding this comment.
can you remove this conditional (and the debian? one below), since we're doing the exact same thing on both platforms
olivielpeau
approved these changes
Jul 3, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Let's merge as soon as the CI pipeline is green
derekwbrown
pushed a commit
that referenced
this pull request
Jul 11, 2017
* adds upstart file to centos6 * adds upstart file to rpm * changes conditional * enables alternative python
derekwbrown
added a commit
that referenced
this pull request
Jul 12, 2017
* [load] adding system check. * [system][iostats] adding iostats check + tests. * [iostats] more precise comment.. * [uptime] adding check + tests. * [load] removing logging statement. * [iostats][test] amending expected number of asserted calls. * [iostats] improve windows support. * [iostats] refactor unix specific io submission, for clarity. * [iostats] refactor, windows numbers differ greatly. Currently not BW compatible. * [iostats] removing unnecessary C(go) header. * [iostats] implement device blacklist. * [iostats] fixing blacklist management + adding test. * [windows] implement windows IO check * Initial checkin of code using both WMI & PDH * Modified APM request * touch up logging. Remove calls to APM * [load] adding system check. * [system][iostats] adding iostats check + tests. * [iostats] more precise comment.. * [load] removing logging statement. * [iostats] improve windows support. * [iostats] refactor unix specific io submission, for clarity. * [iostats] refactor, windows numbers differ greatly. Currently not BW compatible. * [iostats] removing unnecessary C(go) header. * [iostats] implement device blacklist. * [iostats] fixing blacklist management + adding test. * [windows] implement windows IO check * Initial checkin of code using both WMI & PDH * Modified APM request * touch up logging. Remove calls to APM * Switch back to wmi, at least for now. Neither PDH nor WMI is picking up disk changes, at least in the manner tested. * Fix problems with merge * Fix merge. Currently uses WMI; will re-add pdh based IO check at a later date * Changes to reflect review feedback * centos6 changes (#354) * adds upstart file to centos6 * adds upstart file to rpm * changes conditional * enables alternative python * Fix gitlab ci so ci testing can continue * Final review feedback. Make string conversion more efficient by using a byte buffer to do the original conversion, rather than appending a character on to the string for each pass. * Final review feedback. Make string conversion more efficient by using a byte buffer to do the original conversion, rather than appending a character on to the string for each pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is what we needed to change to get this working on centos6. We needed to enable the alternative python (see the related container PR). And we needed to add an upstart file.
Motivation
It had to be done.
Additional Notes
Kenafah needs to sign off on all these changes as well, as mentioned in the container PR this will affect them as well.