Skip to content

[py] Remove agent6-specific python checks#371

Merged
olivielpeau merged 2 commits intomasterfrom
olivielpeau/remove-agent6-py-checks
Jul 17, 2017
Merged

[py] Remove agent6-specific python checks#371
olivielpeau merged 2 commits intomasterfrom
olivielpeau/remove-agent6-py-checks

Conversation

@olivielpeau
Copy link
Copy Markdown
Member

What does this PR do?

These python checks should be pulled from integrations-core now. They were added at a time when the integrations-core checks weren't fully supported yet.

I've double-checked that the 2 checks work.

Motivation

Clean up repo

Additional Notes

I've also added a body to the AgentCheck.warning method, so that it logs the passed message. We probably want to have a more complete support of warning messages, I've created a card for that.

These python checks should be pulled from integrations-core now.

I've double-checked that those checks do work.
Copy link
Copy Markdown
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@olivielpeau olivielpeau merged commit d5cd9a8 into master Jul 17, 2017
@olivielpeau olivielpeau deleted the olivielpeau/remove-agent6-py-checks branch July 17, 2017 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants