[k8s] Support older versions missing ListDeployment API#374
Merged
conorbranagan merged 1 commit intomasterfrom Jul 10, 2017
Merged
[k8s] Support older versions missing ListDeployment API#374conorbranagan merged 1 commit intomasterfrom
conorbranagan merged 1 commit intomasterfrom
Conversation
Handle the 404 error with an empty list of deployments. The remainder of the code should work as expected. Tested locally with minikube v0.15.0 that runs Kubernetes 1.5 which fails on this API.
hkaj
approved these changes
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Kubernetes metadata provider so it works on v1.5 which does not have the ListDeployment API available. This was tested locally on Minikube v0.15 which runs 1.5. Unfortunately we don't have any integration testing in place (yet) but it certainly should come in the future.
Motivation
The Process Agent which uses this provider was failing on older GKE nodes that use 1.5