[py] Add CheckException subclass#378
Merged
olivielpeau merged 1 commit intomasterfrom Jul 11, 2017
Merged
Conversation
Quite a few `integrations-core` checks use this class of exceptions for some of the exceptions they raise. It makes sense to keep it, it encourages some level of exception granularity in the checks.
masci
approved these changes
Jul 11, 2017
Contributor
masci
left a comment
masci
left a comment
There was a problem hiding this comment.
I agree this belongs here 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
CheckExceptionclass of exceptions for py checks to importand use.
Motivation
Quite a few
integrations-corechecks use this class of exceptionsfor some of the exceptions they raise. It makes sense to keep it: it
encourages some level of exception granularity in the checks.
Additional Notes
If for some reason someone thinks it's better to get rid of this class, it's
possible to modify the
integrations-corechecks instead and declare theclass deprecated.