[percentile] change GKArray methods to value receivers#379
Merged
Conversation
olivielpeau
approved these changes
Jul 11, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
👍 if you're sure this has a positive impact on the performance
There are a few commented-out lines to remove
Contributor
Author
There was a problem hiding this comment.
Ack, sorry - I should have checked more carefully.
jeerim
force-pushed
the
jeerim/percentile_non_pointer
branch
from
feb08e6 to
b8fd6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the methods of GKArray to value receivers.
Motivation
In order to make the sketches more efficient by reducing GC overhead.
Additional Notes
Anything else we should know when reviewing?