[py] Add NetworkCheck class#381
Merged
olivielpeau merged 2 commits intomasterfrom Jul 17, 2017
Merged
Conversation
Thin class that allows running the integrations-core `NetworkCheck`s out of the box. Also, added the `default_integration_http_timeout` config parameter and `AgentCheck` attribute that some checks use.
gmmeyer
reviewed
Jul 14, 2017
| UP = "UP" | ||
|
|
||
|
|
||
| # Deprecated since we don't reporting statuses as events anymore |
Contributor
There was a problem hiding this comment.
I think this should be "aren't" instead of "don't"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a thin
NetworkCheckclass that allows running the integrations-core'sNetworkChecks out of the box.Also, added the
default_integration_http_timeoutconfig parameterand
AgentCheckattribute that some checks use.Motivation
Make
NetworkChecks workAdditional Notes
skip_eventoption) since that's been deprecated since agent 5.3http_check, and it works fine ; different instances can be run in parallel by multiple check runnershttp_checkinstances configured. I'll add that to our backlog