[percentile/forwarder] use v2 endpoint to forward sketch series#382
Merged
[percentile/forwarder] use v2 endpoint to forward sketch series#382
Conversation
olivielpeau
approved these changes
Jul 17, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
👍 feel free to merge!
Not sure why in general we have SubmitV1, SubmitV2 and Submit methods for each type of payload in the forwarder (we should probably only keep SubmitV1 and SubmitV2), but I can clean that up once I have a better idea of what's happening here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses v2 endpoint to forward sketch series.
Motivation
Using protobuf serialization for sketch payloads for their smaller size.
Additional Notes
I am using the exact same logic as the v1 submission for sketch payloads besides the endpoint and serialization. There's no further compression and the api key is passed in the query string. This will be changed to match the v2 submission of other payloads when they are finalized.