Use exec in script that starts the agent#389
Merged
olivielpeau merged 1 commit intomasterfrom Jul 18, 2017
Merged
Conversation
Using `exec` makes the agent process replace the shell script's process instead of starting the agent process as a child process. This is desirable for init systems that can't really track the actual agent process' PID otherwise, and can then fail to track the agent process properly.
gmmeyer
approved these changes
Jul 18, 2017
Contributor
gmmeyer
left a comment
gmmeyer
left a comment
There was a problem hiding this comment.
This is a nice clean solution. Looks good to me!
masci
approved these changes
Jul 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
execin script that starts the agent.Resolves #363
Motivation
Using
execmakes the agent process replace the shell script'sprocess instead of starting the agent process as a child process
of the shell script's process.
This is desirable for init systems that can't really track the actual
agent process' PID otherwise (like upstart, see #363),and can then
fail to track the agent process properly.