Skip to content

Replace batch processor with exporter helper: OTLP ingest#42229

Merged
dd-mergequeue[bot] merged 10 commits intomainfrom
azh/OTAGENT-550
Oct 27, 2025
Merged

Replace batch processor with exporter helper: OTLP ingest#42229
dd-mergequeue[bot] merged 10 commits intomainfrom
azh/OTAGENT-550

Conversation

@RiantZ
Copy link
Copy Markdown
Contributor

@RiantZ RiantZ commented Oct 22, 2025

What does this PR do?

Replace OTLP batch processor by exporter helper inside static OTLP pipelines configuration for CoreAgent.

Motivation

The primary reason for replacement is coming end-of-life for batch processor.
More details: open-telemetry/opentelemetry-collector#8122

Describe how you validated your changes

Setup

  • local core agent + new configuration for otel internal pipeline
  • dev org dashboard to receive logs & metrics
  • custom go application to send logs & metrics every 3 seconds

Test types:

  • Functional verification:
    • Check local batching processing timestampes by instrumenting (locally)
      • function ConsumeMetrics at datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter/exporter.go
      • function ConsumeLogs at datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter/logs_exporter.go
        To print timestamps and parameters of logs & metrics received from batch (exporter helper)
  • Long run tests for 4 hours
  • Short stress test - logs and metrics are emitted at hight speed (1024 per second)

Acceptance criteria:

  • Batch push logs at expected frequency (timestamp verification locally and at dashboard)
  • Data is coming in proper order
  • Data is coming without losses

@github-actions github-actions Bot added the medium review PR review might take time label Oct 22, 2025
@RiantZ RiantZ added the component/otlp PRs and issues related to OTLP ingest label Oct 22, 2025
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Oct 22, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 49a42a7

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${677.08}$$ < $${702.15}$$ $${-0.01}$$ $${165.23}$$ < $${177.79}$$
agent_deb_amd64_fips $${+0.02}$$ $${671.6}$$ < $${696.65}$$ $${-0.01}$$ $${164.27}$$ < $${176.53}$$
agent_heroku_amd64 $${-0}$$ $${336.53}$$ < $${340.18}$$ $${+0}$$ $${89.81}$$ < $${91.08}$$
agent_msi $${+0.01}$$ $${1013.43}$$ < $${1015.38}$$ $${0}$$ $${148.21}$$ < $${150.78}$$
agent_rpm_amd64 $${+0}$$ $${677.07}$$ < $${702.14}$$ $${+0}$$ $${167.44}$$ < $${180.53}$$
agent_rpm_amd64_fips $${+0.02}$$ $${671.59}$$ < $${696.64}$$ $${-0}$$ $${166.11}$$ < $${178.79}$$
agent_rpm_arm64 $${+0}$$ $${667.09}$$ < $${686.31}$$ $${+0.02}$$ $${153.44}$$ < $${161.22}$$
agent_rpm_arm64_fips $${+0}$$ $${662.62}$$ < $${681.84}$$ $${+0}$$ $${152.6}$$ < $${160.18}$$
agent_suse_amd64 $${+0}$$ $${677.07}$$ < $${702.14}$$ $${+0}$$ $${167.44}$$ < $${180.53}$$
agent_suse_amd64_fips $${+0.02}$$ $${671.59}$$ < $${696.64}$$ $${-0}$$ $${166.11}$$ < $${178.79}$$
agent_suse_arm64 $${+0}$$ $${667.09}$$ < $${686.31}$$ $${+0.02}$$ $${153.44}$$ < $${161.22}$$
agent_suse_arm64_fips $${+0}$$ $${662.62}$$ < $${681.84}$$ $${+0}$$ $${152.6}$$ < $${160.18}$$
docker_agent_amd64 $${+0}$$ $${747.64}$$ < $${773.59}$$ $${-0}$$ $${252.08}$$ < $${266.06}$$
docker_agent_arm64 $${+0}$$ $${761.6}$$ < $${781.7}$$ $${+0.02}$$ $${242.7}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${+0}$$ $${938.5}$$ < $${964.45}$$ $${-0}$$ $${320.72}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${+0}$$ $${941.06}$$ < $${961.17}$$ $${-0.01}$$ $${307.29}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${0}$$ $${213.35}$$ < $${213.74}$$ $${+0}$$ $${72.41}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${-0}$$ $${229.24}$$ < $${229.68}$$ $${+0}$$ $${68.68}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.45}$$ < $${39.3}$$ $${+0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.12}$$ < $${37.94}$$ $${+0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.25}$$ < $${29.11}$$ $${+0}$$ $${6.78}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0}$$ $${42.33}$$ < $${54.97}$$ $${+0}$$ $${11.05}$$ < $${14.45}$$
iot_agent_deb_arm64 $${+0}$$ $${40.12}$$ < $${51.9}$$ $${+0}$$ $${9.54}$$ < $${12.63}$$
iot_agent_deb_armhf $${+0}$$ $${40.04}$$ < $${51.84}$$ $${-0}$$ $${9.64}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${+0}$$ $${42.33}$$ < $${54.97}$$ $${+0}$$ $${11.07}$$ < $${14.47}$$
iot_agent_suse_amd64 $${+0}$$ $${42.33}$$ < $${54.97}$$ $${+0}$$ $${11.07}$$ < $${14.47}$$

@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter Bot commented Oct 22, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 56453846-e536-4ece-a92a-9d58b0f96f9e

Baseline: f3b6296
Comparison: f945d1c
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_metrics memory utilization +27.53 [+27.36, +27.69] 1 Logs
docker_containers_memory memory utilization +9.09 [+8.67, +9.51] 1 Logs
otlp_ingest_logs memory utilization -15.59 [-15.70, -15.49] 1 Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -9.34 [-9.99, -8.70] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_metrics memory utilization +27.53 [+27.36, +27.69] 1 Logs
docker_containers_memory memory utilization +9.09 [+8.67, +9.51] 1 Logs
ddot_metrics_sum_delta memory utilization +0.44 [+0.29, +0.59] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.41 [+0.37, +0.45] 1 Logs
quality_gate_idle_all_features memory utilization +0.19 [+0.14, +0.23] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.06 [-0.53, +0.66] 1 Logs
quality_gate_metrics_logs memory utilization +0.04 [-0.17, +0.24] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.60, +0.59] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.59, +0.57] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.63, +0.59] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.03 [-0.27, +0.22] 1 Logs
ddot_logs memory utilization -0.06 [-0.12, -0.00] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.14 [-0.34, +0.06] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.15 [-0.26, -0.03] 1 Logs
ddot_metrics memory utilization -0.24 [-0.41, -0.07] 1 Logs
quality_gate_logs % cpu utilization -0.34 [-3.15, +2.47] 1 Logs bounds checks dashboard
file_tree memory utilization -0.37 [-0.41, -0.32] 1 Logs
quality_gate_idle memory utilization -0.53 [-0.57, -0.49] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.91 [-0.97, -0.86] 1 Logs
docker_containers_cpu % cpu utilization -9.34 [-9.99, -8.70] 1 Logs
otlp_ingest_logs memory utilization -15.59 [-15.70, -15.49] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 8/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@RiantZ RiantZ added qa/done QA done before merge and regressions are covered by tests ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed team/opentelemetry-agent labels Oct 22, 2025
@RiantZ RiantZ requested a review from songy23 October 22, 2025 15:06
@RiantZ RiantZ marked this pull request as ready for review October 22, 2025 15:06
@RiantZ RiantZ requested review from a team as code owners October 22, 2025 15:06
Comment thread comp/otelcol/otlp/map_provider_config_not_serverless.go Outdated
Comment thread comp/otelcol/otlp/map_provider_config_not_serverless.go
@RiantZ RiantZ removed the changelog/no-changelog No changelog entry needed label Oct 23, 2025
@RiantZ RiantZ requested a review from a team as a code owner October 23, 2025 08:44
@RiantZ RiantZ requested a review from mx-psi October 23, 2025 08:50
Comment thread comp/otelcol/otlp/map_provider_config_not_serverless.go Outdated
@RiantZ RiantZ requested a review from songy23 October 23, 2025 14:23
@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Oct 23, 2025
Copy link
Copy Markdown
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one non blocking suggestion, approved!

@RiantZ RiantZ requested a review from mx-psi October 27, 2025 12:14
Copy link
Copy Markdown
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiantZ
Copy link
Copy Markdown
Contributor Author

RiantZ commented Oct 27, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Oct 27, 2025

View all feedbacks in Devflow UI.

2025-10-27 13:14:02 UTC ℹ️ Start processing command /merge


2025-10-27 13:14:07 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 37m (p90).


2025-10-27 13:38:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit 57eccdf into main Oct 27, 2025
272 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the azh/OTAGENT-550 branch October 27, 2025 13:38
@github-actions github-actions Bot added this to the 7.73.0 milestone Oct 27, 2025
liustanley added a commit that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR component/otlp PRs and issues related to OTLP ingest long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants