-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[workloadmeta/collectors/kubeapiserver] Use minimal pod representation #43389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
687c696 to
e8d0dbc
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ffb33d9 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.49 | [-4.47, +1.49] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.97 | [+0.91, +1.04] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.23 | [+0.18, +0.28] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.08 | [+0.03, +0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.12, +0.14] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.01 | [-0.09, +0.11] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.08, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.02 | [-0.15, +0.12] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.02 | [-0.25, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.41, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.42, +0.32] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.46, +0.36] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.05 | [-0.21, +0.11] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.10 | [-0.14, -0.05] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.13 | [-0.17, -0.09] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.17 | [-0.22, -0.13] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.19 | [-0.43, +0.05] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.23 | [-0.39, -0.08] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.25 | [-0.32, -0.18] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.32 | [-0.52, -0.11] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | -0.46 | [-0.53, -0.38] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.85 | [-1.06, -0.64] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.03 | [-2.48, +0.42] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -1.49 | [-4.47, +1.49] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
e8d0dbc to
52a7bda
Compare
d31da4a to
b223090
Compare
| Resource("pods"). | ||
| VersionedParams(&options, metav1.ParameterCodec). | ||
| Do(ctx). | ||
| Into(&podList) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since protobuf is not supported, if kubernetes_apiserver_use_protobuf is enabled, it will fail to deserialize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I think the option is not very widely used, but still, I updated the code so that it fallbacks to the previous behavior when kubernetes_apiserver_use_protobuf is enabled.
| // MinimalContainer contains only the container fields we need | ||
| type MinimalContainer struct { | ||
| Name string `json:"name"` | ||
| Resources corev1.ResourceRequirements `json:"resources,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource.Quantity has unexported fields, deepcopy will fail.
package main
import (
"fmt"
"github.com/mohae/deepcopy"
"k8s.io/apimachinery/pkg/api/resource"
)
func main() {
original := resource.MustParse("100m")
copied := deepcopy.Copy(original).(resource.Quantity)
fmt.Printf("Original: %s (MilliValue: %d)\n", original.String(), original.MilliValue())
fmt.Printf("Copied: %s (MilliValue: %d)\n", copied.String(), copied.MilliValue())
fmt.Printf("Equal: %v\n", original.Equal(copied))
}
Output:
Original: 100m (MilliValue: 100)
Copied: 0 (MilliValue: 0)
Equal: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I've updated the code so that (p *MinimalPod) DeepCopyObject() doesn't rely on github.com/mohae/deepcopy. I've also updated the tests to check for this. This makes the code a bit more complex, but it's needed to fix the issue you mentioned 👍
b223090 to
3593f4c
Compare
|
@zhuminyi I've addressed the 2 issues that you mentioned |
3593f4c to
88b421b
Compare
88b421b to
7c20e23
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
#43389) ### What does this PR do? This PR optimizes the memory usage of the `kubeapiserver` workloadmeta collector. The collector now uses a minimal pod struct with only the fields we actually need. This avoids unmarshalling the full pod. The saved memory is noticeable in clusters with many pods. It's specially important when the Cluster Agent starts, since it needs to fetch all pods from the API server. These changes help lower the memory spike at startup. This is useful when that peak is used to set Kubernetes memory requests. I attach a screenshot from one of the clusters where I tested this. The first chart shows `container.memory.usage.peak` and the second one `container.memory.usage`. In both of them, the second half are pods built from this PR. <img width="1341" height="330" alt="dca_memory" src="https://github.com/user-attachments/assets/1fda6581-fd30-47d1-a929-36cc3b2a775e" /> ### Describe how you validated your changes CI + deploying custom image on some clusters to compare memory usage. Co-authored-by: david.ortiz <david.ortiz@datadoghq.com>
What does this PR do?
This PR optimizes the memory usage of the
kubeapiserverworkloadmeta collector.The collector now uses a minimal pod struct with only the fields we actually need. This avoids unmarshalling the full pod. The saved memory is noticeable in clusters with many pods. It's specially important when the Cluster Agent starts, since it needs to fetch all pods from the API server. These changes help lower the memory spike at startup. This is useful when that peak is used to set Kubernetes memory requests.
I attach a screenshot from one of the clusters where I tested this.
The first chart shows
container.memory.usage.peakand the second onecontainer.memory.usage. In both of them, the second half are pods built from this PR.Describe how you validated your changes
CI + deploying custom image on some clusters to compare memory usage.