Skip to content

[ACTP-1046] sync more PAR code to agent (#4)#43809

Merged
dd-mergequeue[bot] merged 9 commits intomainfrom
gabriel.plassard/ACTP-1046/sync-par-to-agent-4
Dec 15, 2025
Merged

[ACTP-1046] sync more PAR code to agent (#4)#43809
dd-mergequeue[bot] merged 9 commits intomainfrom
gabriel.plassard/ACTP-1046/sync-par-to-agent-4

Conversation

@dd-gplassard
Copy link
Copy Markdown
Contributor

@dd-gplassard dd-gplassard commented Dec 4, 2025

What does this PR do?

This syncs additional code from the original PAR into the datadog agent (all the gitlab bundles)

Motivation

We want to integrate the PAR in the agent

Describe how you validated your changes

Code is not called yet and won't be packaged into any of the existing agents binaries, so the quality gate failing is linked to the broader quality gate incident rather than this PR

Additional Notes

Requires #agent-devx review because of the change to the license file for the gitlab client, discussion about this in our #opensource channel
Previous PR : #43599
More PRs to come

@dd-gplassard dd-gplassard changed the title [ACTP-1046] sync more PAR code to agent (#3) [ACTP-1046] sync more PAR code to agent (#4) Dec 4, 2025
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Dec 4, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 625a8b1

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${705.47}$$ < $${706.32}$$ $${-0}$$ $${172.88}$$ < $${173.81}$$
agent_deb_amd64_fips $${+0.01}$$ $${700.81}$$ < $${701.16}$$ $${+0.04}$$ $${171.86}$$ < $${172.71}$$
agent_heroku_amd64 $${+0}$$ $${327.27}$$ < $${327.69}$$ $${-0}$$ $${87.23}$$ < $${88.19}$$
agent_msi $${+0}$$ $${569.56}$$ < $${982.08}$$ $${+0.02}$$ $${142.02}$$ < $${143.01}$$
agent_rpm_amd64 $${+0}$$ $${705.46}$$ < $${706.31}$$ $${-0.03}$$ $${175.86}$$ < $${176.86}$$
agent_rpm_amd64_fips $${+0.01}$$ $${700.8}$$ < $${701.15}$$ $${+0.01}$$ $${173.98}$$ < $${174.95}$$
agent_rpm_arm64 $${+0}$$ $${691.16}$$ < $${691.67}$$ $${-0.02}$$ $${159.7}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0}$$ $${687.38}$$ < $${687.54}$$ $${+0.03}$$ $${159.09}$$ < $${160.1}$$
agent_suse_amd64 $${+0}$$ $${705.46}$$ < $${706.31}$$ $${-0.03}$$ $${175.86}$$ < $${176.86}$$
agent_suse_amd64_fips $${+0.01}$$ $${700.8}$$ < $${701.15}$$ $${+0.01}$$ $${173.98}$$ < $${174.95}$$
agent_suse_arm64 $${+0}$$ $${691.16}$$ < $${691.67}$$ $${-0.02}$$ $${159.7}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0}$$ $${687.38}$$ < $${687.54}$$ $${+0.03}$$ $${159.09}$$ < $${160.1}$$
docker_agent_amd64 $${+0}$$ $${767.8}$$ < $${768.66}$$ $${-0}$$ $${260.62}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.78}$$ < $${778.35}$$ $${+0}$$ $${250.8}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${958.68}$$ < $${959.54}$$ $${-0}$$ $${329.26}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${957.38}$$ < $${957.95}$$ $${+0}$$ $${315.43}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.11}$$ < $${179.28}$$ $${+0.01}$$ $${63.25}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${+0.06}$$ $${196.64}$$ < $${196.79}$$ $${+0}$$ $${59.96}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.67}$$ < $${39.3}$$ $${-0}$$ $${14.94}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.36}$$ < $${37.94}$$ $${+0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.4}$$ < $${29.11}$$ $${+0}$$ $${6.82}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.36}$$ < $${40.92}$$ $${-0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.26}$$ < $${40.86}$$ $${-0}$$ $${9.7}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${+0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${+0}$$ $${11.14}$$ < $${12.0}$$

@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter Bot commented Dec 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 93c1e922-a493-4430-8d6f-fb8416228337

Baseline: 625a8b1
Comparison: 5533845
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.55 [-3.57, +2.48] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.60 [+0.54, +0.66] 1 Logs
otlp_ingest_logs memory utilization +0.47 [+0.37, +0.57] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.36 [+0.31, +0.41] 1 Logs
docker_containers_memory memory utilization +0.29 [+0.21, +0.37] 1 Logs
ddot_metrics memory utilization +0.26 [+0.03, +0.49] 1 Logs
ddot_metrics_sum_delta memory utilization +0.24 [+0.02, +0.46] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.21 [+0.04, +0.38] 1 Logs
quality_gate_idle_all_features memory utilization +0.16 [+0.12, +0.20] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.33, +0.48] 1 Logs
quality_gate_logs % cpu utilization +0.04 [-1.44, +1.51] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.02, +0.07] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.07] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.12] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.15, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.41, +0.37] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.39, +0.35] 1 Logs
otlp_ingest_metrics memory utilization -0.09 [-0.24, +0.06] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.24, -0.15] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.42 [-0.65, -0.19] 1 Logs
ddot_logs memory utilization -0.45 [-0.52, -0.38] 1 Logs
docker_containers_cpu % cpu utilization -0.55 [-3.57, +2.48] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.65 [-0.72, -0.58] 1 Logs
quality_gate_metrics_logs memory utilization -0.86 [-1.08, -0.65] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Base automatically changed from gabriel.plassard/ACTP-1046/sync-par-to-agent-bundles to main December 8, 2025 10:57
@dd-gplassard dd-gplassard force-pushed the gabriel.plassard/ACTP-1046/sync-par-to-agent-4 branch from 743aa69 to 327d69c Compare December 9, 2025 18:04
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Dec 9, 2025
@dd-gplassard dd-gplassard added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Dec 9, 2025
@dd-gplassard dd-gplassard force-pushed the gabriel.plassard/ACTP-1046/sync-par-to-agent-4 branch from 50a9ed8 to 080d69b Compare December 10, 2025 17:49
@dd-gplassard dd-gplassard marked this pull request as ready for review December 11, 2025 08:19
@dd-gplassard dd-gplassard requested review from a team as code owners December 11, 2025 08:19
@aiuto aiuto self-assigned this Dec 11, 2025
Comment thread .copyright-overrides.yml
google.golang.org/grpc/*: Copyright 2014 gRPC authors.
github.com/skydive-project/go-debouncer: Copyright (C) 2018 Red Hat, Inc.

# taken from https://gitlab.com/gitlab-org/api/client-go and then `rg --no-filename Copyright | sort | uniq` and then removing Copyright, year and deduplicating
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU! For putting in the instructions to rebuild.

Copy link
Copy Markdown
Contributor

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for agent-build

aiuto added a commit that referenced this pull request Dec 11, 2025
The agent build team is rebuilding how license compliance works and currently has deep expertise in the issues.
There should really be a new github team that can review copyright and license overrides, but, until that time, adding team/agent-build is a decent proxy for the knowledge and accountability.

Sample PR prompting this: #43809

cc: dd-gplassard@
Copy link
Copy Markdown
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok as reviewer of the copyright file

dd-mergequeue Bot pushed a commit that referenced this pull request Dec 12, 2025
The agent build team is rebuilding how license compliance works and currently has deep expertise in the issues. There should really be a new github team that can review copyright and license overrides, but, until that time, adding team/agent-build is a decent proxy for the knowledge and accountability.

Sample PR prompting this: #43809

cc:  @dd-gplassard


Co-authored-by: tony.aiuto <tony.aiuto@datadoghq.com>
@dd-gplassard
Copy link
Copy Markdown
Contributor Author

/merge -m squash

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 15, 2025

View all feedbacks in Devflow UI.

2025-12-15 09:14:36 UTC ℹ️ Start processing command /merge -m squash


2025-12-15 09:14:44 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-15 11:45:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 42m (p90).


2025-12-15 12:26:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-gplassard dd-gplassard requested a review from a team as a code owner December 15, 2025 10:19
@dd-mergequeue dd-mergequeue Bot merged commit af00a0e into main Dec 15, 2025
303 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the gabriel.plassard/ACTP-1046/sync-par-to-agent-4 branch December 15, 2025 12:26
@github-actions github-actions Bot added this to the 7.75.0 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants