[ACTP-1046] sync more PAR code to agent (#4)#43809
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 625a8b1 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.55 | [-3.57, +2.48] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +0.60 | [+0.54, +0.66] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.47 | [+0.37, +0.57] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.36 | [+0.31, +0.41] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.29 | [+0.21, +0.37] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.26 | [+0.03, +0.49] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.24 | [+0.02, +0.46] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.21 | [+0.04, +0.38] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.16 | [+0.12, +0.20] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.33, +0.48] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.04 | [-1.44, +1.51] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.02, +0.07] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.08, +0.07] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.15, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.41, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.39, +0.35] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.09 | [-0.24, +0.06] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.20 | [-0.24, -0.15] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.42 | [-0.65, -0.19] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.45 | [-0.52, -0.38] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.55 | [-3.57, +2.48] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.65 | [-0.72, -0.58] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.86 | [-1.08, -0.65] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
743aa69 to
327d69c
Compare
50a9ed8 to
080d69b
Compare
| google.golang.org/grpc/*: Copyright 2014 gRPC authors. | ||
| github.com/skydive-project/go-debouncer: Copyright (C) 2018 Red Hat, Inc. | ||
|
|
||
| # taken from https://gitlab.com/gitlab-org/api/client-go and then `rg --no-filename Copyright | sort | uniq` and then removing Copyright, year and deduplicating |
There was a problem hiding this comment.
THANK YOU! For putting in the instructions to rebuild.
The agent build team is rebuilding how license compliance works and currently has deep expertise in the issues. There should really be a new github team that can review copyright and license overrides, but, until that time, adding team/agent-build is a decent proxy for the knowledge and accountability. Sample PR prompting this: #43809 cc: dd-gplassard@
chouetz
left a comment
There was a problem hiding this comment.
ok as reviewer of the copyright file
The agent build team is rebuilding how license compliance works and currently has deep expertise in the issues. There should really be a new github team that can review copyright and license overrides, but, until that time, adding team/agent-build is a decent proxy for the knowledge and accountability. Sample PR prompting this: #43809 cc: @dd-gplassard Co-authored-by: tony.aiuto <tony.aiuto@datadoghq.com>
|
/merge -m squash |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
This syncs additional code from the original PAR into the datadog agent (all the gitlab bundles)
Motivation
We want to integrate the PAR in the agent
Describe how you validated your changes
Code is not called yet and won't be packaged into any of the existing agents binaries, so the quality gate failing is linked to the broader quality gate incident rather than this PR
Additional Notes
Requires #agent-devx review because of the change to the license file for the gitlab client, discussion about this in our #opensource channel
Previous PR : #43599
More PRs to come