-
Notifications
You must be signed in to change notification settings - Fork 1.4k
build krb5 with bazel #44326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build krb5 with bazel #44326
Conversation
ff81803 to
88d45e0
Compare
88d45e0 to
806cef0
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 658a645 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.83 | [-4.79, +1.12] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | ddot_metrics_sum_delta | memory utilization | +1.37 | [+1.16, +1.58] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.95 | [+0.72, +1.18] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.43 | [+0.37, +0.49] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.30 | [+0.25, +0.35] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.29 | [-1.17, +1.74] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.26 | [+0.22, +0.31] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.16 | [+0.08, +0.24] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.16 | [+0.09, +0.22] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.13 | [+0.07, +0.19] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.07 | [+0.04, +0.11] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.05 | [-0.19, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.03, +0.07] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.01 | [-0.15, +0.17] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.08, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.40, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.44, +0.40] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.05 | [-0.20, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.06 | [-0.44, +0.31] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.66 | [-0.86, -0.46] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.71 | [-0.81, -0.61] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.83 | [-4.79, +1.12] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
aiuto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor fixes.
|
|
||
| license( | ||
| name = "license", | ||
| license_kinds = ["@rules_license//licenses/spdx:BSD-2-Clause"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is MIT.
I just read the the file to verify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/krb5/krb5/blob/master/NOTICE looks a lot like https://opensource.org/license/bsd-2-clause though.
It's copyrighted by the MIT, but under BSD-2 as far as I can tell
omnibus/config/software/libkrb5.rb
Outdated
| name "libkrb5" | ||
| default_version "1.21.3" | ||
|
|
||
| dependency "openssl3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should try dropping this line too, since you have the dependency in the cc_library
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
7a9d5dd to
1f90b33
Compare
### What does this PR do? Build krb5 with bazel ### Motivation Migration of our 3rd party dependencies to bazel https://datadoghq.atlassian.net/browse/ABLD-274 ### Describe how you validated your changes Local build for linux x86_64 ### Additional Notes This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451 This will drop all the executables that we currently install: ``` bin/compile_et bin/gss-client bin/k5srvutil bin/kadmin bin/kdestroy bin/kinit bin/klist bin/kpasswd bin/krb5-config bin/ksu bin/kswitch bin/ktutil bin/kvno bin/sclient bin/sim_client bin/uuclient ``` and ``` sbin/gss-server sbin/kadmin.local sbin/kadmind sbin/kdb5_util sbin/kprop sbin/kpropd sbin/kproplog sbin/krb5-send-pr sbin/krb5kdc sbin/sim_server sbin/sserver sbin/uuserver ``` Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
This reverts commit c083fa9
This reverts commit c083fa9
### What does this PR do? This reverts commit c083fa9 ### Motivation [#incident-47546](https://dd.enterprise.slack.com/archives/C0A5L0D2M4M) ### Describe how you validated your changes ### Additional Notes Co-authored-by: chouquette <hugo.beauzee@datadoghq.com> Co-authored-by: florent.clarret <florent.clarret@datadoghq.com>
# What does this PR do? This reverts commit c083fa9 # Motivation [#incident-47546](https://dd.enterprise.slack.com/archives/C0A5L0D2M4M) ### Describe how you validated your changes ### Additional Notes Co-authored-by: florent.clarret <florent.clarret@datadoghq.com>
What does this PR do?
Build krb5 with bazel
Motivation
Migration of our 3rd party dependencies to bazel
https://datadoghq.atlassian.net/browse/ABLD-274
Describe how you validated your changes
Local build for linux x86_64
Additional Notes
This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451
This will drop all the executables that we currently install:
and