Skip to content

Conversation

@chouquette
Copy link
Contributor

@chouquette chouquette commented Dec 17, 2025

What does this PR do?

Build krb5 with bazel

Motivation

Migration of our 3rd party dependencies to bazel
https://datadoghq.atlassian.net/browse/ABLD-274

Describe how you validated your changes

Local build for linux x86_64

Additional Notes

This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451

This will drop all the executables that we currently install:

bin/compile_et  
bin/gss-client  
bin/k5srvutil   
bin/kadmin      
bin/kdestroy    
bin/kinit       
bin/klist       
bin/kpasswd     
bin/krb5-config 
bin/ksu         
bin/kswitch     
bin/ktutil      
bin/kvno        
bin/sclient     
bin/sim_client  
bin/uuclient    

and

sbin/gss-server   
sbin/kadmin.local 
sbin/kadmind      
sbin/kdb5_util    
sbin/kprop        
sbin/kpropd       
sbin/kproplog     
sbin/krb5-send-pr 
sbin/krb5kdc      
sbin/sim_server   
sbin/sserver      
sbin/uuserver     

@chouquette chouquette requested a review from a team as a code owner December 17, 2025 09:49
@chouquette chouquette added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 17, 2025
@chouquette chouquette force-pushed the chouquette/bazel/libkrb5 branch from ff81803 to 88d45e0 Compare December 17, 2025 09:52
@github-actions github-actions bot added medium review PR review might take time team/agent-build labels Dec 17, 2025
@chouquette chouquette force-pushed the chouquette/bazel/libkrb5 branch from 88d45e0 to 806cef0 Compare December 17, 2025 15:32
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 658a645

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-1.14}$$ $${705.23}$$ < $${707.13}$$ $${-0.3}$$ $${172.96}$$ < $${174.16}$$
agent_deb_amd64_fips $${-1.14}$$ $${701.46}$$ < $${702.86}$$ $${-0.36}$$ $${172.22}$$ < $${173.5}$$
agent_heroku_amd64 $${0}$$ $${327.54}$$ < $${327.92}$$ $${+0}$$ $${87.22}$$ < $${88.21}$$
agent_msi $${-0}$$ $${570.94}$$ < $${982.08}$$ $${+0.02}$$ $${142.64}$$ < $${143.49}$$
agent_rpm_amd64 $${-1.14}$$ $${705.22}$$ < $${707.12}$$ $${-0.35}$$ $${176.09}$$ < $${177.29}$$
agent_rpm_amd64_fips $${-1.14}$$ $${701.44}$$ < $${702.85}$$ $${-0.47}$$ $${174.95}$$ < $${176.32}$$
agent_rpm_arm64 $${-0.93}$$ $${687.1}$$ < $${691.67}$$ $${-0.37}$$ $${159.04}$$ < $${160.7}$$
agent_rpm_arm64_fips $${-0.93}$$ $${684.16}$$ < $${687.54}$$ $${-0.31}$$ $${158.79}$$ < $${160.11}$$
agent_suse_amd64 $${-1.14}$$ $${705.22}$$ < $${707.12}$$ $${-0.35}$$ $${176.09}$$ < $${177.29}$$
agent_suse_amd64_fips $${-1.14}$$ $${701.44}$$ < $${702.85}$$ $${-0.47}$$ $${174.95}$$ < $${176.32}$$
agent_suse_arm64 $${-0.93}$$ $${687.1}$$ < $${691.67}$$ $${-0.37}$$ $${159.04}$$ < $${160.7}$$
agent_suse_arm64_fips $${-0.93}$$ $${684.16}$$ < $${687.54}$$ $${-0.31}$$ $${158.79}$$ < $${160.11}$$
docker_agent_amd64 $${-1.14}$$ $${767.02}$$ < $${769.38}$$ $${-0.55}$$ $${260.45}$$ < $${262.06}$$
docker_agent_arm64 $${-0.93}$$ $${773.47}$$ < $${778.35}$$ $${-0.55}$$ $${249.55}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-1.14}$$ $${957.9}$$ < $${960.26}$$ $${-0.58}$$ $${329.08}$$ < $${330.69}$$
docker_agent_jmx_arm64 $${-0.93}$$ $${953.07}$$ < $${957.95}$$ $${-0.57}$$ $${314.16}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${179.42}$$ < $${179.56}$$ $${+0}$$ $${63.43}$$ < $${64.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${195.37}$$ < $${196.79}$$ $${+0}$$ $${59.75}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.13}$$ < $${7.18}$$ $${-0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.75}$$ < $${39.38}$$ $${+0}$$ $${15.0}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.06}$$ < $${37.94}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${-0}$$ $${7.93}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.13}$$ < $${29.11}$$ $${+0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.74}$$ < $${43.29}$$ $${-0}$$ $${11.19}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${39.88}$$ < $${40.92}$$ $${+0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.45}$$ < $${41.03}$$ $${+0}$$ $${9.77}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.74}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.74}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$

@chouquette chouquette added the ask-review Ask required teams to review this PR label Dec 17, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 17, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 91f21a57-8cd2-4ef1-b0f8-e78add2021e4

Baseline: 658a645
Comparison: 1f90b33
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.83 [-4.79, +1.12] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_metrics_sum_delta memory utilization +1.37 [+1.16, +1.58] 1 Logs
ddot_metrics memory utilization +0.95 [+0.72, +1.18] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.43 [+0.37, +0.49] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.30 [+0.25, +0.35] 1 Logs
quality_gate_logs % cpu utilization +0.29 [-1.17, +1.74] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.26 [+0.22, +0.31] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.16 [+0.08, +0.24] 1 Logs
file_tree memory utilization +0.16 [+0.09, +0.22] 1 Logs
ddot_logs memory utilization +0.13 [+0.07, +0.19] 1 Logs
quality_gate_idle_all_features memory utilization +0.07 [+0.04, +0.11] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.05 [-0.19, +0.28] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.03, +0.07] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.01 [-0.15, +0.17] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.13, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.40, +0.36] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.44, +0.40] 1 Logs
otlp_ingest_metrics memory utilization -0.05 [-0.20, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.44, +0.31] 1 Logs
quality_gate_metrics_logs memory utilization -0.66 [-0.86, -0.46] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.71 [-0.81, -0.61] 1 Logs
docker_containers_cpu % cpu utilization -1.83 [-4.79, +1.12] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor fixes.


license(
name = "license",
license_kinds = ["@rules_license//licenses/spdx:BSD-2-Clause"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is MIT.
I just read the the file to verify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/krb5/krb5/blob/master/NOTICE looks a lot like https://opensource.org/license/bsd-2-clause though.
It's copyrighted by the MIT, but under BSD-2 as far as I can tell

name "libkrb5"
default_version "1.21.3"

dependency "openssl3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try dropping this line too, since you have the dependency in the cc_library

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 18, 2025

View all feedbacks in Devflow UI.

2025-12-18 07:32:30 UTC ℹ️ Start processing command /merge


2025-12-18 07:32:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-18 10:34:05 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-12-18 11:22:04 UTC ℹ️ MergeQueue: This merge request was merged

@chouquette chouquette force-pushed the chouquette/bazel/libkrb5 branch from 7a9d5dd to 1f90b33 Compare December 18, 2025 08:57
@dd-mergequeue dd-mergequeue bot merged commit c083fa9 into main Dec 18, 2025
436 checks passed
@dd-mergequeue dd-mergequeue bot deleted the chouquette/bazel/libkrb5 branch December 18, 2025 11:22
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 18, 2025
mwdd146980 pushed a commit that referenced this pull request Dec 23, 2025
### What does this PR do?

Build krb5 with bazel

### Motivation

Migration of our 3rd party dependencies to bazel
https://datadoghq.atlassian.net/browse/ABLD-274

### Describe how you validated your changes

Local build for linux x86_64

### Additional Notes

This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451

This will drop all the executables that we currently install:
```
bin/compile_et
bin/gss-client
bin/k5srvutil
bin/kadmin
bin/kdestroy
bin/kinit
bin/klist
bin/kpasswd
bin/krb5-config
bin/ksu
bin/kswitch
bin/ktutil
bin/kvno
bin/sclient
bin/sim_client
bin/uuclient
```
and
```
sbin/gss-server
sbin/kadmin.local
sbin/kadmind
sbin/kdb5_util
sbin/kprop
sbin/kpropd
sbin/kproplog
sbin/krb5-send-pr
sbin/krb5kdc
sbin/sim_server
sbin/sserver
sbin/uuserver
```

Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
FlorentClarret pushed a commit that referenced this pull request Dec 29, 2025
FlorentClarret added a commit that referenced this pull request Dec 29, 2025
dd-mergequeue bot pushed a commit that referenced this pull request Dec 29, 2025
### What does this PR do?

This reverts commit c083fa9

### Motivation

[#incident-47546](https://dd.enterprise.slack.com/archives/C0A5L0D2M4M)

### Describe how you validated your changes

### Additional Notes


Co-authored-by: chouquette <hugo.beauzee@datadoghq.com>
Co-authored-by: florent.clarret <florent.clarret@datadoghq.com>
dd-mergequeue bot pushed a commit that referenced this pull request Dec 29, 2025
# What does this PR do?

This reverts commit c083fa9

# Motivation
[#incident-47546](https://dd.enterprise.slack.com/archives/C0A5L0D2M4M)

### Describe how you validated your changes

### Additional Notes


Co-authored-by: florent.clarret <florent.clarret@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants