Skip to content

[AGENTRUN-784] feat: Rust-based shared library checks core with an example check#45815

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits intomainfrom
maxime.chambre/AGENTRUN-784-shlib-check-rust-core-and-example
Mar 6, 2026
Merged

[AGENTRUN-784] feat: Rust-based shared library checks core with an example check#45815
gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits intomainfrom
maxime.chambre/AGENTRUN-784-shlib-check-rust-core-and-example

Conversation

@Enzu83
Copy link
Copy Markdown
Contributor

@Enzu83 Enzu83 commented Feb 2, 2026

What does this PR do?

This PR adds the core part of Rust-based checks and an example of a Rust-based shared library check.

The core part acts as the glue code between the check implementation in Rust and the Agent (Running the check, passing configuration, sending metrics...). Each check includes the core part in their implementation.

Motivation

Provide the source code for shared library checks used by the shared library loader implemented in:

Describe how you validated your changes

  • Compile the example check (package example) and have it loaded, scheduled and run by the Agent.
  • Verify that the metrics, service checks and events are correctly sent to the backend.
    They are defined in pkg/collector/sharedlibrary/rustchecks/checks/example/src/check.rs

Additional Notes

This code isn't used in the build or in any jobs, it's put here to experiment with Rust-based shared library checks.

@github-actions github-actions Bot added long review PR is complex, plan time to review it team/agent-runtimes labels Feb 2, 2026
@Enzu83 Enzu83 changed the title feat: Rust-based shared library checks core with an example check [AGENTRUN-784] feat: Rust-based shared library checks core with an example check Feb 2, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Feb 2, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ed28000
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 745.227 MiB
agent_deb_amd64_fips 703.579 MiB
agent_heroku_amd64 311.555 MiB
agent_msi 609.362 MiB
agent_rpm_amd64 745.211 MiB
agent_rpm_amd64_fips 703.562 MiB
agent_rpm_arm64 723.273 MiB
agent_rpm_arm64_fips 684.614 MiB
agent_suse_amd64 745.211 MiB
agent_suse_amd64_fips 703.562 MiB
agent_suse_arm64 723.273 MiB
agent_suse_arm64_fips 684.614 MiB
docker_agent_amd64 805.557 MiB
docker_agent_arm64 808.417 MiB
docker_agent_jmx_amd64 996.473 MiB
docker_agent_jmx_arm64 988.111 MiB
docker_cluster_agent_amd64 203.566 MiB
docker_cluster_agent_arm64 217.975 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.611 MiB
docker_dogstatsd_arm64 36.938 MiB
dogstatsd_deb_amd64 29.835 MiB
dogstatsd_deb_arm64 27.988 MiB
dogstatsd_rpm_amd64 29.835 MiB
dogstatsd_suse_amd64 29.835 MiB
iot_agent_deb_amd64 43.041 MiB
iot_agent_deb_arm64 40.103 MiB
iot_agent_deb_armhf 40.843 MiB
iot_agent_rpm_amd64 43.041 MiB
iot_agent_suse_amd64 43.041 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -41.21 KiB (0.02% reduction) 173.969 → 173.928 → 177.700
agent_deb_amd64_fips -8.31 KiB (0.00% reduction) 164.834 → 164.826 → 172.230
agent_heroku_amd64 -3.5 KiB (0.00% reduction) 75.126 → 75.123 → 79.970
agent_msi +12.0 KiB (0.01% increase) 137.918 → 137.930 → 146.220
agent_rpm_amd64 +21.88 KiB (0.01% increase) 175.912 → 175.934 → 180.780
agent_rpm_amd64_fips -10.97 KiB (0.01% reduction) 167.780 → 167.769 → 173.370
agent_rpm_arm64 -41.98 KiB (0.03% reduction) 158.321 → 158.280 → 161.610
agent_rpm_arm64_fips -32.71 KiB (0.02% reduction) 151.126 → 151.094 → 155.910
agent_suse_amd64 +21.88 KiB (0.01% increase) 175.912 → 175.934 → 180.780
agent_suse_amd64_fips -10.97 KiB (0.01% reduction) 167.780 → 167.769 → 173.370
agent_suse_arm64 -41.98 KiB (0.03% reduction) 158.321 → 158.280 → 161.610
agent_suse_arm64_fips -32.71 KiB (0.02% reduction) 151.126 → 151.094 → 155.910
docker_agent_amd64 neutral 266.500 MiB → 271.240
docker_agent_arm64 neutral 253.768 MiB → 259.800
docker_agent_jmx_amd64 neutral 335.143 MiB → 339.870
docker_agent_jmx_arm64 -4.44 KiB (0.00% reduction) 318.411 → 318.407 → 324.390
docker_cluster_agent_amd64 neutral 71.249 MiB → 71.920
docker_cluster_agent_arm64 neutral 66.890 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.727 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.943 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.272 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.884 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.767 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.894 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.894 MiB → 8.800
iot_agent_deb_amd64 neutral 11.353 MiB → 12.040
iot_agent_deb_arm64 neutral 9.663 MiB → 10.450
iot_agent_deb_armhf neutral 9.893 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.371 MiB → 12.060
iot_agent_suse_amd64 neutral 11.371 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Feb 2, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cced9e9c-f5c8-481a-aced-1355b4397524

Baseline: 38280a8
Comparison: d58e743
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.45 [-5.50, +0.59] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_metrics memory utilization +0.40 [+0.24, +0.55] 1 Logs
ddot_metrics_sum_delta memory utilization +0.16 [+0.00, +0.33] 1 Logs
quality_gate_metrics_logs memory utilization +0.13 [-0.09, +0.35] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.05 [+0.01, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.37, +0.46] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.47, +0.49] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.13, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.39, +0.38] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.09, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.11] 1 Logs
quality_gate_idle memory utilization -0.03 [-0.07, +0.01] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.03 [-0.07, +0.01] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.07 [-0.12, -0.01] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.15 [-0.29, -0.00] 1 Logs
file_tree memory utilization -0.27 [-0.32, -0.22] 1 Logs
ddot_logs memory utilization -0.36 [-0.43, -0.29] 1 Logs
otlp_ingest_logs memory utilization -0.42 [-0.52, -0.32] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.43 [-0.50, -0.36] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.45 [-0.67, -0.23] 1 Logs
ddot_metrics memory utilization -0.50 [-0.67, -0.33] 1 Logs
quality_gate_logs % cpu utilization -0.71 [-2.17, +0.75] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.71 [-0.78, -0.65] 1 Logs
docker_containers_cpu % cpu utilization -2.45 [-5.50, +0.59] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@Enzu83 Enzu83 added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog No changelog entry needed labels Feb 3, 2026
@Enzu83 Enzu83 force-pushed the maxime.chambre/AGENTRUN-784-shlib-check-rust-core-and-example branch from c9db976 to 767cb8e Compare February 4, 2026 13:07
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Feb 9, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Feb 24, 2026

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

@dd-octo-sts dd-octo-sts Bot added the stale label Feb 24, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Mar 5, 2026

Files inventory check summary

File checks results against ancestor ed280008:

Results for datadog-agent_7.78.0~devel.git.354.bd3a0ce.pipeline.100854018-1_amd64.deb:

No change detected

@Enzu83 Enzu83 marked this pull request as ready for review March 5, 2026 20:33
@Enzu83 Enzu83 requested a review from a team as a code owner March 5, 2026 20:33
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 895e5517ca

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread pkg/collector/sharedlibrary/rustchecks/core/src/ffi.rs Outdated
Comment thread pkg/collector/sharedlibrary/rustchecks/core/src/ffi.rs
@dd-octo-sts dd-octo-sts Bot removed the stale label Mar 5, 2026
Copy link
Copy Markdown
Contributor

@fabbing fabbing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a preview method to have Rust checks, but the interfaces will change to make the checks compatible with the Slim check interface and compatibility with ADP/ACR.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit d58e743 into main Mar 6, 2026
284 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the maxime.chambre/AGENTRUN-784-shlib-check-rust-core-and-example branch March 6, 2026 12:16
@github-actions github-actions Bot added this to the 7.78.0 milestone Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants