feat(health-platform): persist issues to disk across restarts#46069
feat(health-platform): persist issues to disk across restarts#46069gh-worker-dd-mergequeue-cf854d[bot] merged 20 commits intomainfrom
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
4 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 476c330 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.00 | [-4.07, +2.08] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.43 | [+1.35, +1.52] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +1.37 | [+1.15, +1.58] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | +1.12 | [+0.91, +1.32] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.69 | [+0.58, +0.80] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.37 | [+0.34, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.28 | [+0.23, +0.32] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.23 | [+0.08, +0.38] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.18 | [+0.02, +0.33] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.13 | [+0.08, +0.18] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.09 | [-0.14, +0.32] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.02 | [-0.11, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.10] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.13, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.39, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.07, +0.00] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.04 | [-0.45, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.08 | [-0.58, +0.42] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.12 | [-0.19, -0.05] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.22 | [-0.27, -0.16] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.26 | [-0.32, -0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.68 | [-0.88, -0.48] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.00 | [-4.07, +2.08] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.22 | [-2.72, +0.29] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
| // IssueStateOngoing indicates an issue that persists across checks | ||
| IssueStateOngoing IssueState = "ongoing" | ||
| // IssueStateResolved indicates an issue that has been resolved | ||
| IssueStateResolved IssueState = "resolved" |
There was a problem hiding this comment.
💬 suggestion
We should update the payload on agent-payload` side to pass the resolved state to Recommendations
There was a problem hiding this comment.
the state is added to agent-payload, waiting it to be released to bump the package in the agent and fill it with the state update, in the meanwhile you can review the big e2e test if you want
| []healthplatform.IssueState{healthplatform.IssueState_ISSUE_STATE_NEW, healthplatform.IssueState_ISSUE_STATE_ONGOING}, | ||
| dockerIssue.PersistedIssue.State, "PersistedIssue state should be NEW or ONGOING") |
There was a problem hiding this comment.
💭 thought
Should we test for a new issue and then that it turns to on going? Maybe too complex in a blackbox test
| // Verify that the docker permission issue NEVER appears in any health report after the fix. | ||
| // No payload at all is also acceptable — it means there are no issues to report. | ||
| require.Never(t, func() bool { | ||
| payloads, err := fakeIntake.GetAgentHealth() |
There was a problem hiding this comment.
❓ question
Don't we send it with status:fixed?
There was a problem hiding this comment.
Will follow up on it in an other PRs
pducolin
left a comment
There was a problem hiding this comment.
Only minor comments, nice!
What does this PR do?
Adds on-disk persistence for Health Platform issues so they survive agent restarts. The component now writes a JSON state file under
<run_path>/health-platform/issues.json, restores issues on startup, and tracks per-check issue lifecycle state (new,ongoing,resolved) with timestamps.Motivation
Health issues were previously stored only in memory, so restarting the agent cleared the current health view and made troubleshooting harder. Persisting issues improves continuity for diagnostics, local endpoint visibility, and support workflows.
Describe how you validated your changes
CI + manual QA:
Additional Notes
Writes are atomic (temp file + rename). Persistence is updated on issue updates and clears. Issues restored from disk are rebuilt from the registry; resolved issues are not rehydrated into the active issues map.
Workflow example:
Agent start #1:
Agent stops
Agent start #2: