Skip to content

feat(health-platform): persist issues to disk across restarts#46069

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 20 commits intomainfrom
louis-cqrl/AH-write-issue-on-disk
Feb 24, 2026
Merged

feat(health-platform): persist issues to disk across restarts#46069
gh-worker-dd-mergequeue-cf854d[bot] merged 20 commits intomainfrom
louis-cqrl/AH-write-issue-on-disk

Conversation

@louis-cqrl
Copy link
Copy Markdown
Contributor

@louis-cqrl louis-cqrl commented Feb 9, 2026

What does this PR do?

Adds on-disk persistence for Health Platform issues so they survive agent restarts. The component now writes a JSON state file under <run_path>/health-platform/issues.json, restores issues on startup, and tracks per-check issue lifecycle state (new, ongoing, resolved) with timestamps.

Motivation

Health issues were previously stored only in memory, so restarting the agent cleared the current health view and made troubleshooting harder. Persisting issues improves continuity for diagnostics, local endpoint visibility, and support workflows.

Describe how you validated your changes

CI + manual QA:

cat /opt/datadog-agent/run/health-platform/issues.json
{
  "updated_at": "2026-02-12T13:31:47Z",
  "issues": {
    "docker-socket-permissions": {
      "issue_id": "docker-file-tailing-disabled",
      "state": "new",
      "first_seen": "2026-02-12T13:31:47Z",
      "last_seen": "2026-02-12T13:31:47Z"
    }
  }
}
cat /opt/datadog-agent/run/health-platform/issues.json
{
  "updated_at": "2026-02-12T14:26:51Z",
  "issues": {
    "docker": {
      "issue_id": "check-execution-failure",
      "state": "ongoing",
      "first_seen": "2026-02-12T13:35:25Z",
      "last_seen": "2026-02-12T14:26:51Z"
    },
    "docker-socket-permissions": {
      "issue_id": "docker-file-tailing-disabled",
      "state": "resolved",
      "first_seen": "2026-02-12T13:31:47Z",
      "last_seen": "2026-02-12T13:31:47Z",
      "resolved_at": "2026-02-12T14:26:33Z"
    },
    "logs-docker-file-permissions": {
      "issue_id": "docker-file-tailing-disabled",
      "state": "ongoing",
      "first_seen": "2026-02-12T13:35:08Z",
      "last_seen": "2026-02-12T13:35:08Z"
    }
  }
}

Additional Notes

Writes are atomic (temp file + rename). Persistence is updated on issue updates and clears. Issues restored from disk are rebuilt from the registry; resolved issues are not rehydrated into the active issues map.

Workflow example:

Agent start #1:

  • Detect issue 1 → {issue_id: "issue-1", state: "new", first_seen: T1}
  • Detect issue 2 → {issue_id: "issue-2", state: "new", first_seen: T1}
  • Later, detect issue 3 → {issue_id: "issue-3", state: "new", first_seen: T2}
  • Issue 1 detected again → {state: "ongoing", last_seen: T3}
  • Issue 2 resolved → {state: "resolved", resolved_at: T4}

Agent stops

Agent start #2:

  • Load file, restore active issues (issue 1, issue 3)
  • Check runs, issue 1 is now resolved → {state: "resolved", resolved_at: T5}
  • Check runs, issue 3 still present → {state: "ongoing", last_seen: T5}
  • Final state: issue 1 resolved, issue 2 resolved, issue 3 ongoing ✓

@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Feb 9, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Feb 9, 2026
@louis-cqrl louis-cqrl added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests and removed medium review PR review might take time labels Feb 9, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Feb 9, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor dc3c3c7
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +26.79 KiB (0.00% increase) 756.636 → 756.662 → 759.670
agent_deb_amd64_fips +22.82 KiB (0.00% increase) 715.137 → 715.160 → 720.180
agent_heroku_amd64 +24.56 KiB (0.01% increase) 323.765 → 323.789 → 329.530
agent_msi +33.5 KiB (0.01% increase) 622.715 → 622.747 → 1073.220
agent_rpm_amd64 +26.79 KiB (0.00% increase) 756.619 → 756.645 → 759.640
agent_rpm_amd64_fips +22.82 KiB (0.00% increase) 715.121 → 715.143 → 720.160
agent_rpm_arm64 +19.66 KiB (0.00% increase) 734.733 → 734.752 → 741.840
agent_rpm_arm64_fips +19.66 KiB (0.00% increase) 696.260 → 696.279 → 703.390
agent_suse_amd64 +26.79 KiB (0.00% increase) 756.619 → 756.645 → 759.640
agent_suse_amd64_fips +22.82 KiB (0.00% increase) 715.121 → 715.143 → 720.160
agent_suse_arm64 +19.66 KiB (0.00% increase) 734.733 → 734.752 → 741.840
agent_suse_arm64_fips +19.66 KiB (0.00% increase) 696.260 → 696.279 → 703.390
docker_agent_amd64 +26.73 KiB (0.00% increase) 817.657 → 817.683 → 821.990
docker_agent_arm64 +19.59 KiB (0.00% increase) 820.506 → 820.525 → 828.520
docker_agent_jmx_amd64 +26.73 KiB (0.00% increase) 1008.568 → 1008.594 → 1012.870
docker_agent_jmx_arm64 +19.58 KiB (0.00% increase) 1000.200 → 1000.219 → 1008.120
docker_cluster_agent_amd64 +8.48 KiB (0.00% increase) 203.414 → 203.422 → 204.270
docker_dogstatsd_amd64 +4.47 KiB (0.01% increase) 38.504 → 38.508 → 39.380
dogstatsd_deb_amd64 +8.47 KiB (0.03% increase) 29.724 → 29.732 → 30.610
dogstatsd_deb_arm64 +8.47 KiB (0.03% increase) 27.881 → 27.889 → 29.110
dogstatsd_rpm_amd64 +8.47 KiB (0.03% increase) 29.724 → 29.732 → 30.610
dogstatsd_suse_amd64 +8.47 KiB (0.03% increase) 29.724 → 29.732 → 30.610
iot_agent_deb_amd64 +20.5 KiB (0.05% increase) 42.613 → 42.633 → 43.290
iot_agent_deb_arm64 +20.53 KiB (0.05% increase) 39.714 → 39.734 → 40.920
iot_agent_deb_armhf +24.47 KiB (0.06% increase) 40.439 → 40.463 → 41.030
iot_agent_rpm_amd64 +20.5 KiB (0.05% increase) 42.613 → 42.633 → 43.290
iot_agent_suse_amd64 +20.5 KiB (0.05% increase) 42.613 → 42.633 → 43.290
4 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_arm64 217.834 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_arm64 36.812 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +12.57 KiB (0.01% increase) 185.704 → 185.716 → 186.090
agent_deb_amd64_fips -7.09 KiB (0.00% reduction) 176.272 → 176.265 → 180.330
agent_heroku_amd64 -11.84 KiB (0.01% reduction) 87.103 → 87.092 → 88.440
agent_msi +20.0 KiB (0.01% increase) 149.336 → 149.355 → 154.470
agent_rpm_amd64 +59.88 KiB (0.03% increase) 187.564 → 187.623 → 189.170
agent_rpm_amd64_fips -24.41 KiB (0.01% reduction) 178.450 → 178.426 → 181.060
agent_rpm_arm64 -45.19 KiB (0.03% reduction) 169.869 → 169.825 → 170.020
agent_rpm_arm64_fips +31.82 KiB (0.02% increase) 162.480 → 162.512 → 164.130
agent_suse_amd64 +59.88 KiB (0.03% increase) 187.564 → 187.623 → 189.170
agent_suse_amd64_fips -24.41 KiB (0.01% reduction) 178.450 → 178.426 → 181.060
agent_suse_arm64 -45.19 KiB (0.03% reduction) 169.869 → 169.825 → 170.020
agent_suse_arm64_fips +31.82 KiB (0.02% increase) 162.480 → 162.512 → 164.130
docker_agent_amd64 -14.71 KiB (0.01% reduction) 277.928 → 277.913 → 279.410
docker_agent_arm64 +20.14 KiB (0.01% increase) 265.190 → 265.210 → 267.960
docker_agent_jmx_amd64 neutral 346.569 MiB → 348.040
docker_agent_jmx_arm64 -11.23 KiB (0.00% reduction) 329.842 → 329.831 → 332.560
docker_cluster_agent_amd64 +3.01 KiB (0.00% increase) 71.196 → 71.199 → 71.920
docker_cluster_agent_arm64 neutral 66.831 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 +2.18 KiB (0.01% increase) 14.901 → 14.903 → 15.820
docker_dogstatsd_arm64 neutral 14.238 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.855 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.742 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.867 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.867 MiB → 8.800
iot_agent_deb_amd64 +5.66 KiB (0.05% increase) 11.235 → 11.240 → 12.040
iot_agent_deb_arm64 +4.29 KiB (0.04% increase) 9.598 → 9.602 → 10.450
iot_agent_deb_armhf +2.91 KiB (0.03% increase) 9.801 → 9.804 → 10.620
iot_agent_rpm_amd64 +7.75 KiB (0.07% increase) 11.251 → 11.258 → 12.060
iot_agent_suse_amd64 +7.75 KiB (0.07% increase) 11.251 → 11.258 → 12.060

@github-actions github-actions Bot added the medium review PR review might take time label Feb 12, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Feb 12, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0328a9d9-8b87-44b0-9603-fce1882adbfb

Baseline: 476c330
Comparison: 51a30a2
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.00 [-4.07, +2.08] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.43 [+1.35, +1.52] 1 Logs
quality_gate_metrics_logs memory utilization +1.37 [+1.15, +1.58] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +1.12 [+0.91, +1.32] 1 Logs
otlp_ingest_logs memory utilization +0.69 [+0.58, +0.80] 1 Logs
quality_gate_idle_all_features memory utilization +0.37 [+0.34, +0.41] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.28 [+0.23, +0.32] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.23 [+0.08, +0.38] 1 Logs
otlp_ingest_metrics memory utilization +0.18 [+0.02, +0.33] 1 Logs
file_tree memory utilization +0.13 [+0.08, +0.18] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.09 [-0.14, +0.32] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.11, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.10] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.39, +0.37] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.07, +0.00] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.45, +0.38] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.58, +0.42] 1 Logs
docker_containers_memory memory utilization -0.12 [-0.19, -0.05] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.22 [-0.27, -0.16] 1 Logs
ddot_logs memory utilization -0.26 [-0.32, -0.19] 1 Logs
ddot_metrics_sum_delta memory utilization -0.68 [-0.88, -0.48] 1 Logs
docker_containers_cpu % cpu utilization -1.00 [-4.07, +2.08] 1 Logs
quality_gate_logs % cpu utilization -1.22 [-2.72, +0.29] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@louis-cqrl louis-cqrl marked this pull request as ready for review February 12, 2026 14:29
@louis-cqrl louis-cqrl requested a review from a team as a code owner February 12, 2026 14:29
@louis-cqrl louis-cqrl marked this pull request as draft February 12, 2026 15:17
// IssueStateOngoing indicates an issue that persists across checks
IssueStateOngoing IssueState = "ongoing"
// IssueStateResolved indicates an issue that has been resolved
IssueStateResolved IssueState = "resolved"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion
We should update the payload on agent-payload` side to pass the resolved state to Recommendations

Copy link
Copy Markdown
Contributor Author

@louis-cqrl louis-cqrl Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the state is added to agent-payload, waiting it to be released to bump the package in the agent and fill it with the state update, in the meanwhile you can review the big e2e test if you want

@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Feb 18, 2026
@louis-cqrl louis-cqrl marked this pull request as ready for review February 18, 2026 14:49
@louis-cqrl louis-cqrl requested a review from pducolin February 18, 2026 14:49
@louis-cqrl louis-cqrl requested a review from a team as a code owner February 18, 2026 16:17
Comment thread comp/healthplatform/impl/health-platform.go
Comment thread comp/healthplatform/impl/health-platform.go
Comment thread test/new-e2e/tests/agent-health/docker_permission_test.go Outdated
Comment thread test/new-e2e/tests/agent-health/docker_permission_test.go Outdated
@louis-cqrl louis-cqrl requested a review from pducolin February 24, 2026 09:39
Comment thread test/new-e2e/tests/agent-health/docker_permission_test.go Outdated
Comment on lines +111 to +112
[]healthplatform.IssueState{healthplatform.IssueState_ISSUE_STATE_NEW, healthplatform.IssueState_ISSUE_STATE_ONGOING},
dockerIssue.PersistedIssue.State, "PersistedIssue state should be NEW or ONGOING")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought
Should we test for a new issue and then that it turns to on going? Maybe too complex in a blackbox test

Comment thread test/new-e2e/tests/agent-health/docker_permission_test.go Outdated
// Verify that the docker permission issue NEVER appears in any health report after the fix.
// No payload at all is also acceptable — it means there are no issues to report.
require.Never(t, func() bool {
payloads, err := fakeIntake.GetAgentHealth()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question
Don't we send it with status:fixed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow up on it in an other PRs

Copy link
Copy Markdown
Collaborator

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, nice!

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 08ef955 into main Feb 24, 2026
621 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the louis-cqrl/AH-write-issue-on-disk branch February 24, 2026 17:00
@github-actions github-actions Bot added this to the 7.78.0 milestone Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants