Skip to content

[#incident-49623] Replace the gopsutil version with the old release before regression#46594

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
incident-49623/revert-gopsutil-upgrade-v4.25.11
Feb 19, 2026
Merged

[#incident-49623] Replace the gopsutil version with the old release before regression#46594
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
incident-49623/revert-gopsutil-upgrade-v4.25.11

Conversation

@jeremy-hanna
Copy link
Copy Markdown
Contributor

What does this PR do?

#45287 introduced a version upgrade for gopsutil which had a regression (shirou/gopsutil#1931) with device naming / tagging in the disk check. Still investigating.

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 17, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 17, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Feb 17, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c74c8f6
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -7.66 KiB (0.00% reduction) 756.132 → 756.124 → 759.670
agent_deb_amd64_fips -3.66 KiB (0.00% reduction) 715.036 → 715.032 → 720.180
agent_heroku_amd64 -7.91 KiB (0.00% reduction) 323.701 → 323.693 → 329.530
agent_rpm_amd64 -7.66 KiB (0.00% reduction) 756.115 → 756.108 → 759.640
agent_rpm_amd64_fips -3.66 KiB (0.00% reduction) 715.019 → 715.016 → 720.160
agent_rpm_arm64 -7.59 KiB (0.00% reduction) 734.369 → 734.362 → 741.840
agent_rpm_arm64_fips -7.62 KiB (0.00% reduction) 696.189 → 696.181 → 703.390
agent_suse_amd64 -7.66 KiB (0.00% reduction) 756.115 → 756.108 → 759.640
agent_suse_amd64_fips -3.66 KiB (0.00% reduction) 715.019 → 715.016 → 720.160
agent_suse_arm64 -7.59 KiB (0.00% reduction) 734.369 → 734.362 → 741.840
agent_suse_arm64_fips -7.62 KiB (0.00% reduction) 696.189 → 696.181 → 703.390
docker_agent_amd64 -7.69 KiB (0.00% reduction) 817.181 → 817.174 → 821.990
docker_agent_arm64 -7.62 KiB (0.00% reduction) 820.154 → 820.147 → 828.520
docker_agent_jmx_amd64 -7.69 KiB (0.00% reduction) 1008.093 → 1008.085 → 1012.870
docker_agent_jmx_arm64 -7.62 KiB (0.00% reduction) 999.848 → 999.841 → 1008.120
docker_cluster_agent_amd64 +4.71 KiB (0.00% increase) 190.101 → 190.106 → 191.320
dogstatsd_deb_amd64 -3.97 KiB (0.01% reduction) 29.716 → 29.712 → 30.610
dogstatsd_deb_arm64 -3.97 KiB (0.01% reduction) 27.876 → 27.872 → 29.110
dogstatsd_rpm_amd64 -3.97 KiB (0.01% reduction) 29.716 → 29.712 → 30.610
dogstatsd_suse_amd64 -3.97 KiB (0.01% reduction) 29.716 → 29.712 → 30.610
iot_agent_deb_amd64 -3.97 KiB (0.01% reduction) 42.609 → 42.605 → 43.290
iot_agent_deb_armhf -3.95 KiB (0.01% reduction) 40.439 → 40.435 → 41.030
iot_agent_rpm_amd64 -3.97 KiB (0.01% reduction) 42.609 → 42.605 → 43.290
iot_agent_suse_amd64 -3.97 KiB (0.01% reduction) 42.609 → 42.605 → 43.290
7 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_msi 622.220 MiB
docker_cluster_agent_arm64 205.502 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.496 MiB
docker_dogstatsd_arm64 36.812 MiB
iot_agent_deb_arm64 39.710 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -47.32 KiB (0.02% reduction) 185.501 → 185.454 → 186.090
agent_deb_amd64_fips -4.03 KiB (0.00% reduction) 176.164 → 176.160 → 180.330
agent_heroku_amd64 neutral 87.122 MiB → 88.440
agent_msi +4.0 KiB (0.00% increase) 138.375 → 138.379 → 143.470
agent_rpm_amd64 -15.09 KiB (0.01% reduction) 187.316 → 187.302 → 189.170
agent_rpm_amd64_fips -12.05 KiB (0.01% reduction) 178.268 → 178.257 → 181.060
agent_rpm_arm64 -2.1 KiB (0.00% reduction) 169.363 → 169.361 → 170.020
agent_rpm_arm64_fips +22.29 KiB (0.01% increase) 162.321 → 162.343 → 164.130
agent_suse_amd64 -15.09 KiB (0.01% reduction) 187.316 → 187.302 → 189.170
agent_suse_amd64_fips -12.05 KiB (0.01% reduction) 178.268 → 178.257 → 181.060
agent_suse_arm64 -2.1 KiB (0.00% reduction) 169.363 → 169.361 → 170.020
agent_suse_arm64_fips +22.29 KiB (0.01% increase) 162.321 → 162.343 → 164.130
docker_agent_amd64 -2.69 KiB (0.00% reduction) 277.650 → 277.647 → 279.410
docker_agent_arm64 -3.19 KiB (0.00% reduction) 264.956 → 264.953 → 267.960
docker_agent_jmx_amd64 +2.17 KiB (0.00% increase) 346.295 → 346.297 → 348.040
docker_agent_jmx_arm64 -5.43 KiB (0.00% reduction) 329.595 → 329.589 → 332.560
docker_cluster_agent_amd64 -2.37 KiB (0.00% reduction) 66.449 → 66.447 → 67.220
docker_cluster_agent_arm64 +4.16 KiB (0.01% increase) 62.498 → 62.502 → 63.640
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.234 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.739 MiB → 7.710
dogstatsd_rpm_amd64 -2.81 KiB (0.03% reduction) 7.865 → 7.863 → 8.800
dogstatsd_suse_amd64 -2.81 KiB (0.03% reduction) 7.865 → 7.863 → 8.800
iot_agent_deb_amd64 -4.52 KiB (0.04% reduction) 11.236 → 11.231 → 12.040
iot_agent_deb_arm64 neutral 9.599 MiB → 10.450
iot_agent_deb_armhf neutral 9.800 MiB → 10.620
iot_agent_rpm_amd64 -3.42 KiB (0.03% reduction) 11.254 → 11.251 → 12.060
iot_agent_suse_amd64 -3.42 KiB (0.03% reduction) 11.254 → 11.251 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Feb 17, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 979d7771-5567-4327-942c-a55b38058418

Baseline: c74c8f6
Comparison: 1c05315
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.70 [-6.71, -0.68] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.87 [+0.77, +0.97] 1 Logs
ddot_metrics memory utilization +0.46 [+0.23, +0.68] 1 Logs
quality_gate_logs % cpu utilization +0.42 [-1.08, +1.92] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.24 [+0.01, +0.47] 1 Logs
file_tree memory utilization +0.24 [+0.19, +0.29] 1 Logs
ddot_logs memory utilization +0.18 [+0.11, +0.25] 1 Logs
quality_gate_idle memory utilization +0.09 [+0.05, +0.13] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [-0.00, +0.12] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.38, +0.37] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.41] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.15, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.08, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.57, +0.37] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.18 [-0.33, -0.02] 1 Logs
quality_gate_idle_all_features memory utilization -0.28 [-0.32, -0.24] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.28 [-0.50, -0.07] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.34 [-0.44, -0.23] 1 Logs
docker_containers_memory memory utilization -0.36 [-0.43, -0.28] 1 Logs
ddot_metrics_sum_delta memory utilization -0.41 [-0.60, -0.21] 1 Logs
otlp_ingest_metrics memory utilization -0.42 [-0.58, -0.26] 1 Logs
docker_containers_cpu % cpu utilization -3.70 [-6.71, -0.68] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@jose-manuel-almaza jose-manuel-almaza requested a review from a team as a code owner February 18, 2026 07:28
@jose-manuel-almaza jose-manuel-almaza added ask-review Ask required teams to review this PR team/agent-runtimes qa/done QA done before merge and regressions are covered by tests labels Feb 18, 2026
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 18, 2026
@jose-manuel-almaza jose-manuel-almaza added the changelog/no-changelog No changelog entry needed label Feb 18, 2026
@jeremy-hanna
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 04:36:57 UTC ℹ️ Start processing command /merge


2026-02-19 04:37:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-19 04:37:38 UTC ⚠️ MergeQueue: This merge request was unqueued

jeremy.hanna@datadoghq.com unqueued this merge request

@jeremy-hanna
Copy link
Copy Markdown
Contributor Author

/merge --cancel

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 04:37:34 UTC ℹ️ Start processing command /merge --cancel

@jeremy-hanna
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 04:59:21 UTC ℹ️ Start processing command /merge


2026-02-19 04:59:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-19 06:01:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-02-19 06:41:11 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 57f4072 into main Feb 19, 2026
590 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the incident-49623/revert-gopsutil-upgrade-v4.25.11 branch February 19, 2026 06:41
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants