Provide secret module implementation in core bundle#46806
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom Feb 25, 2026
Merged
Provide secret module implementation in core bundle#46806gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
Conversation
github-actions
Bot
added
component/system-probe
long review
dd-octo-sts
Bot
added
internal
Contributor
Go Package Import DifferencesBaseline: 77fc7ad
|
pgimalac
added
changelog/no-changelog
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
13 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 77fc7ad Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.61 | [-4.65, +1.44] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.87 | [+1.80, +1.95] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +1.39 | [+1.31, +1.47] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.63 | [+0.47, +0.79] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.62 | [+0.42, +0.83] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.55 | [+0.51, +0.60] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.39 | [+0.33, +0.46] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.26 | [+0.20, +0.31] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.24 | [+0.18, +0.29] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.20 | [+0.04, +0.36] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.18 | [+0.14, +0.21] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.16 | [-0.04, +0.36] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.05 | [-0.05, +0.15] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.41, +0.50] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.04 | [-0.19, +0.27] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.12, +0.15] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.11, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.10, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.04 | [-0.47, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.10, -0.01] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.06 | [-0.44, +0.32] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.63 | [-2.11, +0.85] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.69 | [-0.90, -0.48] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -1.61 | [-4.65, +1.44] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Alos222
approved these changes
Feb 23, 2026
songy23
approved these changes
Feb 23, 2026
khewonc
approved these changes
Feb 23, 2026
steveny91
approved these changes
Feb 23, 2026
brycekahle
approved these changes
Feb 23, 2026
hmahmood
approved these changes
Feb 23, 2026
dustmop
reviewed
Feb 23, 2026
Contributor
dustmop
left a comment
dustmop
left a comment
There was a problem hiding this comment.
It looks like there's a few places where this change is modifying semantics, either adding or removing the secrets component to a command, which doesn't seem intentional. Please let me know if I'm missing something.
| SysprobeConfigParams: sysprobeconfigimpl.NewParams(), | ||
| LogParams: log.ForDaemon(command.LoggerName, "log_file", defaultpaths.LogFile), | ||
| }), | ||
| secretsfx.Module(), |
Contributor
There was a problem hiding this comment.
Does this disable secrets for the window agent? In other places in this PR you replace secretsfx.Module() with a call to core.Bundle(core.WithSecrets()) but I don't see a corresponding inclusion for this file.
Member
Author
There was a problem hiding this comment.
For this one actually the core.Bundle is in getSharedFxOption(), and it has WithSecrets()
pgimalac
commented
Feb 23, 2026
| SysprobeConfigParams: sysprobeconfigimpl.NewParams(), | ||
| LogParams: log.ForDaemon(command.LoggerName, "log_file", defaultpaths.LogFile), | ||
| }), | ||
| secretsfx.Module(), |
Member
Author
There was a problem hiding this comment.
For this one actually the core.Bundle is in getSharedFxOption(), and it has WithSecrets()
dustmop
approved these changes
Feb 24, 2026
BaptisteFoy
approved these changes
Feb 24, 2026
theomagellan
approved these changes
Feb 24, 2026
mellon85
approved these changes
Feb 24, 2026
DanielLavie
approved these changes
Feb 24, 2026
L3n41c
approved these changes
Feb 24, 2026
chrisnad
approved these changes
Feb 24, 2026
jedupau
approved these changes
Feb 25, 2026
YoannGh
approved these changes
Feb 25, 2026
…/core-bundle-secret-module
…/core-bundle-secret-module
julien-lebot
approved these changes
Feb 25, 2026
Contributor
Files inventory check summaryFile checks results against ancestor 77fc7adf: Results for datadog-agent_7.78.0~devel.git.109.c20ecee.pipeline.98843892-1_amd64.deb:No change detected |
lebauce
approved these changes
Feb 25, 2026
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
pgimalac/core-bundle-secret-module
branch
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
### What does this PR do? Provide secret component implementation in core bundle through a functional option pattern. ### Motivation The core bundle should be self sufficient, importing it and still having to provide some extra modules is surprising and annoying. The delegated auth token (being introduced in #46272) has the exact same issue and will require being included along with secrets, with this change it can just be imported directly within the core bundle like the secret component, requiring no change to any command. ### Describe how you validated your changes CI ### Additional Notes This means all binaries will now import both the "real" and the "noop" implementation of the secret component, potentially resulting in more dependencies, but it should already be the case anyway, the run commands use the real secret component while most other subcommands use the noop, so both are imported. If the size impact is too big, `WithSecrets` can be moved to a different package so that only binaries using it get its dependencies. Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com> 351ba46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provide secret component implementation in core bundle through a functional option pattern.
Motivation
The core bundle should be self sufficient, importing it and still having to provide some extra modules is surprising and annoying.
The delegated auth token (being introduced in #46272) has the exact same issue and will require being included along with secrets, with this change it can just be imported directly within the core bundle like the secret component, requiring no change to any command.
Describe how you validated your changes
CI
Additional Notes
This means all binaries will now import both the "real" and the "noop" implementation of the secret component, potentially resulting in more dependencies, but it should already be the case anyway, the run commands use the real secret component while most other subcommands use the noop, so both are imported.
If the size impact is too big,
WithSecretscan be moved to a different package so that only binaries using it get its dependencies.