Delegated auth integration testing#47282
Closed
wynbennett wants to merge 64 commits intomainfrom
Closed
Conversation
Introduces the comp/core/delegatedauth component for cloud-based API key retrieval using delegated authentication (AWS SigV4). Also adds pkg/util/aws/creds for AWS credential detection and handling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
# Conflicts: # go.mod
Module consolidation: - Consolidate 9 separate Go modules into a single comp/core/delegatedauth module - Keep api/cloudauth/aws as a separate module to isolate AWS SDK dependency - This enables future cloud providers (GCP, Azure) to be added as separate modules without bloating the core dependency graph Graceful noop behavior: - Initialize() now succeeds even when no supported cloud provider is detected - AddInstance() becomes a noop on unsupported platforms instead of erroring - Agent gracefully falls back to traditional API key method - Debug logs available for troubleshooting This change makes delegated auth easier to deploy in mixed environments where some agents run on AWS and others run on-prem or other clouds. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…2b.yaml Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
…duplicate hostnameimpl.MockModule() issues.
…6c.yaml Co-authored-by: May Lee <may.lee@datadoghq.com>
…6c.yaml Co-authored-by: May Lee <may.lee@datadoghq.com>
…ated_auth_integration # Conflicts: # releasenotes/notes/Cloud-auth-to-get-an-API-key-2611285702bdf36c.yaml
This reverts commit 34256a3.
…ated_auth_integration
…ated_auth_integration
…ated_auth_integration # Conflicts: # comp/core/ipc/httphelpers/go.mod # comp/core/ipc/impl/go.mod # comp/core/ipc/mock/go.mod # comp/core/log/fx/go.mod # comp/core/status/statusimpl/go.mod # comp/core/tagger/impl-remote/go.mod # comp/forwarder/defaultforwarder/go.mod # comp/forwarder/orchestrator/orchestratorinterface/go.mod # comp/logs/agent/config/go.mod # comp/otelcol/converter/impl/go.mod # comp/otelcol/ddflareextension/impl/go.mod # comp/otelcol/otlp/components/exporter/datadogexporter/go.mod # comp/otelcol/otlp/components/exporter/datadogexporter/go.sum # comp/otelcol/otlp/components/exporter/serializerexporter/go.mod # comp/otelcol/otlp/components/exporter/serializerexporter/go.sum # comp/otelcol/otlp/components/processor/infraattributesprocessor/go.mod # comp/otelcol/otlp/testutil/go.mod # comp/otelcol/status/impl/go.mod # comp/serializer/logscompression/go.mod # comp/serializer/metricscompression/go.mod # go.mod # pkg/api/go.mod # pkg/config/remote/go.mod # pkg/config/utils/endpoints.go # pkg/util/compression/go.mod # pkg/util/grpc/go.mod # pkg/util/kubernetes/apiserver/common/namespace/go.mod # test/otel/go.mod
…ated_auth_integration # Conflicts: # comp/otelcol/logsagentpipeline/go.mod # comp/otelcol/logsagentpipeline/logsagentpipelineimpl/go.mod # comp/otelcol/otlp/components/exporter/datadogexporter/go.sum # comp/otelcol/otlp/components/exporter/serializerexporter/go.mod # comp/otelcol/otlp/components/exporter/serializerexporter/go.sum
…ou would always want delegatedAuth injected if you are using secrets
System-probe already uses secretsnoopfx.Module() (the noop version of secrets), so it should use delegatedauthnoopfx.Module() for consistency. Delegated auth is designed to work with secrets to fetch API keys dynamically, which isn't applicable when secrets aren't supported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
# Conflicts: # comp/otelcol/collector-contrib/impl/go.mod # comp/otelcol/ddflareextension/impl/go.mod # comp/otelcol/ddprofilingextension/impl/go.mod # comp/otelcol/otlp/components/exporter/datadogexporter/go.mod # comp/otelcol/otlp/components/exporter/datadogexporter/go.sum # comp/otelcol/otlp/components/exporter/logsagentexporter/go.mod # comp/otelcol/otlp/components/exporter/serializerexporter/go.mod # comp/otelcol/otlp/components/exporter/serializerexporter/go.sum # go.mod # test/otel/go.mod
dd-octo-sts
Bot
added
internal
Contributor
Go Package Import DifferencesBaseline: 4db738e
|
wynbennett
changed the title
Contributor
Files inventory check summaryFile checks results against ancestor 4db738ee: Results for datadog-agent_7.78.0~devel.git.284.7ce7d63.pipeline.100144702-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
3 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 4db738e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.67 | [-4.68, +1.35] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +0.70 | [+0.50, +0.90] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.64 | [+0.60, +0.69] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.39 | [-1.10, +1.88] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.29 | [+0.25, +0.34] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.27 | [+0.08, +0.47] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.21 | [+0.17, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.13 | [-0.07, +0.33] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.38, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.00 | [-0.43, +0.43] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.09, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.15, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.52, +0.46] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.07, +0.01] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.27 | [-0.34, -0.20] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.30 | [-0.40, -0.21] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.37 | [-0.60, -0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.40 | [-0.45, -0.34] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.62 | [-0.72, -0.51] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.67 | [-0.83, -0.51] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.70 | [-0.86, -0.54] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.00 | [-1.08, -0.93] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.67 | [-4.68, +1.35] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mirror of #46291 with a shorter branch name for IT testing