fix(devcontainer): add platform option for amd64 images#47757
Conversation
Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
Files inventory check summaryFile checks results against ancestor 178cf93a: Results for datadog-agent_7.78.0~devel.git.760.ba07388.pipeline.103679749-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 83828e2 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.22 | [-0.87, +5.32] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.22 | [-0.87, +5.32] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.57 | [+0.40, +0.74] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.52 | [+0.38, +0.66] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.37 | [+0.15, +0.60] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.14 | [+0.10, +0.18] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.14 | [+0.07, +0.20] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.10 | [-0.00, +0.19] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.09 | [+0.04, +0.14] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.09 | [+0.04, +0.15] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.03 | [-0.03, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.08, +0.09] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.12, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.21, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.49, +0.46] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.44, +0.34] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.06 | [-1.65, +1.53] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.07 | [-0.50, +0.36] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.30 | [-0.38, -0.22] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.57 | [-0.75, -0.39] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.84 | [-1.00, -0.68] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.17 | [-1.30, -1.04] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.63 | [-1.87, -1.39] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 727 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 273.54MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 697 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.72MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 2 ≤ 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 494.17MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 203.39MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 355.79 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 409.16MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
There was a problem hiding this comment.
Pull request overview
This PR updates the devcontainer configuration generator to explicitly set Docker’s target platform when running an amd64 devcontainer image, avoiding incorrect default platform selection on multi-arch hosts (e.g., Apple Silicon).
Changes:
- Adds
--platform=linux/amd64to the generatedrunArgswhen the devcontainer image is detected as amd64.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
What does this PR do?
Adds an explicit
--platform=linux/amd64run argument when the devcontainer image is an amd64 image, so Docker runs it with the correct architecture.Motivation
On hosts where Docker may default to a different platform (e.g., Apple Silicon), amd64 devcontainer images can be pulled/run with the wrong architecture/emulation unless the platform is specified.
Describe how you validated your changes
runArgsincludes--platform=linux/amd64when using an amd64 devcontainer image.Additional Notes
tasks/devcontainer.pyand only applies when"amd64"is present in the image name.