Skip to content

Revert "[EBPF] gpu: add validation task against live metrics"#48449

Merged
chouetz merged 1 commit intomainfrom
revert-46885-guillermo.julian/live-validation-script
Mar 27, 2026
Merged

Revert "[EBPF] gpu: add validation task against live metrics"#48449
chouetz merged 1 commit intomainfrom
revert-46885-guillermo.julian/live-validation-script

Conversation

@datadog-prod-us1-3
Copy link
Copy Markdown
Contributor

@datadog-prod-us1-3 datadog-prod-us1-3 Bot commented Mar 26, 2026

Automatic revert of commit b63ccef.
This PR is created to anticipate the resolution of tests_linux-x64-py3 job failure in main branch in case of erroneous code change.
If this revert is incorrect, do not hesitate to close the PR.

@datadog-prod-us1-3 datadog-prod-us1-3 Bot requested review from a team as code owners March 26, 2026 17:52
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Mar 26, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Mar 26, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 8b46676f:

Results for datadog-agent_7.79.0~devel.git.212.f3c23b6.pipeline.104614893-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8b46676
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 752.580 MiB
agent_deb_amd64_fips 709.602 MiB
agent_heroku_amd64 313.301 MiB
agent_rpm_amd64 752.564 MiB
agent_rpm_amd64_fips 709.586 MiB
agent_rpm_arm64 731.003 MiB
agent_rpm_arm64_fips 691.026 MiB
agent_suse_amd64 752.564 MiB
agent_suse_amd64_fips 709.586 MiB
agent_suse_arm64 731.003 MiB
agent_suse_arm64_fips 691.026 MiB
docker_agent_amd64 812.882 MiB
docker_agent_arm64 816.092 MiB
docker_agent_jmx_amd64 1003.798 MiB
docker_agent_jmx_arm64 995.786 MiB
docker_cluster_agent_amd64 203.942 MiB
docker_cluster_agent_arm64 218.420 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.238 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.881 MiB
dogstatsd_deb_arm64 28.034 MiB
dogstatsd_rpm_amd64 29.881 MiB
dogstatsd_suse_amd64 29.881 MiB
iot_agent_deb_amd64 43.278 MiB
iot_agent_deb_arm64 40.324 MiB
iot_agent_deb_armhf 41.076 MiB
iot_agent_rpm_amd64 43.278 MiB
iot_agent_suse_amd64 43.278 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +65.09 KiB (0.04% increase) 174.742 → 174.805 → 178.360
agent_deb_amd64_fips -9.64 KiB (0.01% reduction) 165.329 → 165.319 → 172.790
agent_heroku_amd64 -4.73 KiB (0.01% reduction) 75.004 → 74.999 → 79.970
agent_rpm_amd64 -26.15 KiB (0.01% reduction) 177.564 → 177.538 → 181.830
agent_rpm_amd64_fips -31.2 KiB (0.02% reduction) 167.655 → 167.625 → 173.370
agent_rpm_arm64 -17.24 KiB (0.01% reduction) 159.499 → 159.482 → 163.060
agent_rpm_arm64_fips -51.4 KiB (0.03% reduction) 151.375 → 151.325 → 156.170
agent_suse_amd64 -26.15 KiB (0.01% reduction) 177.564 → 177.538 → 181.830
agent_suse_amd64_fips -31.2 KiB (0.02% reduction) 167.655 → 167.625 → 173.370
agent_suse_arm64 -17.24 KiB (0.01% reduction) 159.499 → 159.482 → 163.060
agent_suse_arm64_fips -51.4 KiB (0.03% reduction) 151.375 → 151.325 → 156.170
docker_agent_amd64 neutral 268.104 MiB → 272.480
docker_agent_arm64 neutral 255.296 MiB → 261.060
docker_agent_jmx_amd64 neutral 336.751 MiB → 341.100
docker_agent_jmx_arm64 neutral 319.927 MiB → 325.620
docker_cluster_agent_amd64 neutral 71.373 MiB → 72.920
docker_cluster_agent_arm64 neutral 67.013 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.174 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.494 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.894 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.778 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.903 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.903 MiB → 8.800
iot_agent_deb_amd64 -2.15 KiB (0.02% reduction) 11.401 → 11.399 → 12.040
iot_agent_deb_arm64 neutral 9.702 MiB → 10.450
iot_agent_deb_armhf neutral 9.940 MiB → 10.620
iot_agent_rpm_amd64 -3.43 KiB (0.03% reduction) 11.420 → 11.416 → 12.060
iot_agent_suse_amd64 -3.43 KiB (0.03% reduction) 11.420 → 11.416 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Mar 26, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 860141c3-ce72-4b40-a8dc-c8e709e4d228

Baseline: 50b7138
Comparison: 605a112
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.40 [+0.38, +6.42] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.40 [+0.38, +6.42] 1 Logs
quality_gate_logs % cpu utilization +1.59 [-0.04, +3.22] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.66 [+0.54, +0.78] 1 Logs
ddot_metrics memory utilization +0.57 [+0.39, +0.75] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.37 [+0.15, +0.60] 1 Logs
ddot_metrics_sum_delta memory utilization +0.36 [+0.19, +0.52] 1 Logs
quality_gate_idle memory utilization +0.24 [+0.19, +0.29] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.02, +0.11] 1 Logs
quality_gate_metrics_logs memory utilization +0.02 [-0.23, +0.26] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.51, +0.53] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.21] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.45, +0.46] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.10, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.37, +0.37] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.21, +0.19] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.02 [-0.07, +0.04] 1 Logs
otlp_ingest_metrics memory utilization -0.08 [-0.24, +0.08] 1 Logs
ddot_logs memory utilization -0.16 [-0.22, -0.09] 1 Logs
quality_gate_idle_all_features memory utilization -0.22 [-0.25, -0.18] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.23 [-0.33, -0.14] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.25 [-0.37, -0.13] 1 Logs
file_tree memory utilization -0.30 [-0.35, -0.24] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.52 [-0.67, -0.38] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 700 ≥ 26
docker_containers_memory memory_usage 10/10 275.47MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 683 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 9/10 175.10MiB > 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 497.66MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 205.99MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 355.72 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 423.07MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouetz chouetz merged commit 605a112 into main Mar 27, 2026
268 of 277 checks passed
@chouetz chouetz deleted the revert-46885-guillermo.julian/live-validation-script branch March 27, 2026 08:02
@github-actions github-actions Bot added this to the 7.79.0 milestone Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot internal Identify a non-fork PR long review PR is complex, plan time to review it team/agent-devx team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant