Try fix all tests#48453
Draft
KevinFairise2 wants to merge 2 commits intomainfrom
Draft
Conversation
dd-octo-sts
Bot
added
internal
Contributor
Gitlab CI Configuration ChangesModified Jobsworkflow (configuration) workflow:
rules:
- if: $CI_PIPELINE_SOURCE == "trigger" || $CI_PIPELINE_SOURCE == "pipeline"
- if: $CI_COMMIT_BRANCH == "main"
variables:
BAZEL_CACHE_POLICY_SUFFIX: -push
GO_TEST_SKIP_FLAKE: 'false'
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
- if: $RUN_E2E_TESTS == "on"
- if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
- changes:
compare_to: main
paths:
- '**/*_windows.go'
- pkg/util/winutil/**/*
- pkg/windowsdriver/**/*
- pkg/util/pdhutil/**/*
- pkg/util/crashreport/**/*
- pkg/collector/corechecks/system/wincrashdetect/**/*
- pkg/collector/corechecks/system/windowscertificate/**/*
- pkg/collector/corechecks/system/winkmem/**/*
- pkg/collector/corechecks/system/winproc/**/*
- pkg/collector/corechecks/net/wlan/**/*
- pkg/logs/launchers/windowsevent/**/*
- pkg/logs/tailers/windowsevent/**/*
- pkg/logs/util/windowsevent/**/*
- pkg/network/driver/**/*
+ - pkg/config/**/*
- cmd/agent/**/*
- cmd/process-agent/**/*
- cmd/security-agent/**/*
- cmd/otel-agent/**/*
- cmd/privateactionrunner/**/*
- cmd/system-probe/**/*
- cmd/trace-agent/**/*
- cmd/installer/**/*
- cmd/systray/**/*
- cmd/otel-agent/**/*
variables:
SKIP_WINDOWS: 'false'
- changes:
compare_to: main
paths:
- comp/systray/**/*
- comp/updater/**/*
- comp/checks/agentcrashdetect/**/*
- comp/checks/windowseventlog/**/*
- comp/checks/winregistry/**/*
- comp/metadata/hostsysteminfo/**/*
- comp/trace/etwtracer/**/*
- comp/etw/**/*
- comp/notableevents/**/*
- comp/publishermetadatacache/**/*
- comp/softwareinventory/**/*
- tools/windows/**/*
- .bazel*
- MODULE.bazel*
- omnibus/**/*
- packages/**/*
- deps/**/*
- rtloader/**/*
- bazel/**/*
- Dockerfiles/agent/windows/**/*
- Dockerfiles/agent/entrypoint.ps1
- Dockerfiles/agent/entrypoint.d.windows/**/*
- chocolatey/**/*
- tasks/msi.py
- tasks/winbuild.py
- tasks/winbuildscripts/**/*
- tasks/windows_resources.py
- tasks/systray.py
- release.json
- .gitlab-ci.yml
- .gitlab/**/*
variables:
SKIP_WINDOWS: 'false'
- changes:
compare_to: main
paths:
- test/new-e2e/tests/fleet/**/*
- test/new-e2e/tests/installer/windows/**/*
- test/new-e2e/tests/windows/**/*
- test/new-e2e/tests/sysprobe-functional/**/*
variables:
SKIP_WINDOWS: 'false'
- if: $CI_COMMIT_TAG == null
variables:
SKIP_WINDOWS: 'true'.windows_path .windows_path:
- '**/*_windows.go'
- pkg/util/winutil/**/*
- pkg/windowsdriver/**/*
- pkg/util/pdhutil/**/*
- pkg/util/crashreport/**/*
- pkg/collector/corechecks/system/wincrashdetect/**/*
- pkg/collector/corechecks/system/windowscertificate/**/*
- pkg/collector/corechecks/system/winkmem/**/*
- pkg/collector/corechecks/system/winproc/**/*
- pkg/collector/corechecks/net/wlan/**/*
- pkg/logs/launchers/windowsevent/**/*
- pkg/logs/tailers/windowsevent/**/*
- pkg/logs/util/windowsevent/**/*
- pkg/network/driver/**/*
+ - pkg/config/**/*
- cmd/agent/**/*
- cmd/process-agent/**/*
- cmd/security-agent/**/*
- cmd/otel-agent/**/*
- cmd/privateactionrunner/**/*
- cmd/system-probe/**/*
- cmd/trace-agent/**/*
- cmd/installer/**/*
- cmd/systray/**/*
- cmd/otel-agent/**/*Changes Summary
ℹ️ Diff available in the job log. |
KevinFairise2
force-pushed
the
kfairise/fix-unit-tests
branch
from
b6be46c to
da6cf81
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da6cf8151f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths := cfg.GetStringSlice(PARRestrictedShellAllowedPaths) | ||
| assert.Equal(t, []string{ | ||
| filepath.Join(containerizedPathPrefix, defaultLogPath), | ||
| containerizedPathPrefix + "/" + defaultLogPath, |
There was a problem hiding this comment.
This expectation now builds the path with string concatenation, but defaultLogPath already starts with /, so it produces "/host//var/log" while the production code uses path.Join and returns "/host/var/log". As a result, TestPrivateActionRunnerAllowedPathsContainerizedWithoutHostMounts fails consistently when the config setup tests run (for example with go test -tags test ./pkg/config/setup). The expected value should be normalized the same way as the code under test.
Useful? React with 👍 / 👎.
KevinFairise2
force-pushed
the
kfairise/fix-unit-tests
branch
from
4812298 to
d8e820a
Compare
Contributor
Files inventory check summaryFile checks results against ancestor b63ccef9: Results for datadog-agent_7.79.0~devel.git.209.7ce4107.pipeline.104657241-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
KevinFairise2
force-pushed
the
kfairise/fix-unit-tests
branch
from
d8e820a to
9277373
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b63ccef Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.45 | [+0.46, +6.44] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.45 | [+0.46, +6.44] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.32 | [+0.15, +0.50] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.32 | [+0.15, +0.49] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.16 | [+0.08, +0.23] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.09 | [-0.13, +0.32] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.07 | [+0.01, +0.13] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.06 | [+0.00, +0.12] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.02 | [-0.01, +0.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.49, +0.52] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.00 | [-0.42, +0.42] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.21, +0.20] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.19] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.02 | [-0.13, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.07 | [-0.46, +0.33] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.09 | [-0.15, -0.03] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.13 | [-0.36, +0.09] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.19 | [-0.24, -0.14] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.26 | [-0.42, -0.09] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.62 | [-0.76, -0.48] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.65 | [-2.27, +0.97] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -2.00 | [-2.14, -1.86] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 684 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 276.03MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 676 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.14MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 500.76MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 205.24MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 373.25 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 418.48MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
KevinFairise2
force-pushed
the
kfairise/fix-unit-tests
branch
from
9277373 to
7ce4107
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Try to fix unit tests
#46885
#48236
Introduce triggers to make sure they are triggered next time
Motivation
Describe how you validated your changes
Additional Notes