Conversation
…aware pr…" This reverts commit 273e223.
aiuto
added
the
qa/no-code-change
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5aec176392
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
77
to
80
| runner, err := interp.New( | ||
| interp.StdIO(nil, &stdout, &stderr), | ||
| interp.AllowedPaths(h.allowedPaths), | ||
| interp.ProcPath(resolveProcPath()), | ||
| cmdOpt, |
There was a problem hiding this comment.
In containerized Agent deployments, runCommand now creates the interpreter without interp.ProcPath(...), so proc-backed builtins (for example process/network inspection commands) will read the container’s /proc instead of the host-mounted procfs. That produces incorrect results for the common DaemonSet/container case where host proc is exposed at /host/proc, and breaks host-level diagnostics unless every command is reworked manually.
Useful? React with 👍 / 👎.
| } | ||
| } | ||
| config.BindEnvAndSetDefault(PARRestrictedShellAllowedPaths, defaultPaths) | ||
| config.BindEnvAndSetDefault(PARRestrictedShellAllowedPaths, []string{"/var/log"}) |
There was a problem hiding this comment.
The default for private_action_runner.restricted_shell_allowed_paths is now hardcoded to /var/log for all environments, which regresses containerized installs where host logs are mounted under /host/var/log. In that setup, default runCommand access no longer reaches host logs unless operators explicitly override config, so out-of-the-box behavior is broken for container deployments.
Useful? React with 👍 / 👎.
Contributor
Author
|
/trigger_ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on |
Contributor
Files inventory check summaryFile checks results against ancestor e5ab089d: Results for datadog-agent_7.79.0~devel.git.219.5aec176.pipeline.104695979-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
22 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c592740 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.43 | [-3.36, +2.50] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otlp_ingest_logs | memory utilization | +0.88 | [+0.77, +0.99] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.66 | [+0.59, +0.73] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.45 | [+0.21, +0.69] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.38 | [+0.33, +0.43] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.34 | [+0.29, +0.39] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | +0.21 | [+0.03, +0.38] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.19 | [+0.03, +0.35] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.12 | [-0.05, +0.29] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.01, +0.19] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.34, +0.43] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.44, +0.51] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.21, +0.18] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.03 | [-0.24, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.08 | [-0.51, +0.34] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.12 | [-0.16, -0.09] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.16 | [-0.26, -0.07] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.18 | [-0.33, -0.02] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.21 | [-1.83, +1.41] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.28 | [-0.50, -0.06] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.43 | [-3.36, +2.50] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.44 | [-0.50, -0.38] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.55 | [-0.69, -0.41] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 707 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 271.40MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 686 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.59MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 496.07MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 205.51MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 368.40 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 403.89MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
chouetz
deleted the
revert-48236-matt-dz/par-restricted-shell-container-paths
branch
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…ntainer-aware prefixing"" (#48462) Reverts #48460 Revert + this test fix: All tests pass. Here's a summary of the fix: Root cause: Both filepath.Join calls used OS path separators. On Windows, filepath.Join("/host", "/var/log") produces \host\var\log, breaking tests that expected Linux-style paths. Similarly, filepath.Join("/host", "/proc") produced \host\proc which didn't match the mock key /host/proc, causing resolveProcPath to fall back to /proc. Fix: Replaced filepath.Join with path.Join (POSIX package) in three files: - pkg/config/setup/privateactionrunner.go — container path prefix joining - pkg/config/setup/privateactionrunner_test.go — test assertion using same join - pkg/privateactionrunner/bundles/remoteaction/rshell/run_command.go — resolveProcPath These are Linux container paths (/host/...) that must always use forward slashes regardless of the host OS. Co-authored-by: alexandre.yang <alexandre.yang@datadoghq.com>
AlexandreYang
added a commit
that referenced
this pull request
Mar 27, 2026
…ntainer-aware prefixing"" (#48462) Reverts #48460 Revert + this test fix: All tests pass. Here's a summary of the fix: Root cause: Both filepath.Join calls used OS path separators. On Windows, filepath.Join("/host", "/var/log") produces \host\var\log, breaking tests that expected Linux-style paths. Similarly, filepath.Join("/host", "/proc") produced \host\proc which didn't match the mock key /host/proc, causing resolveProcPath to fall back to /proc. Fix: Replaced filepath.Join with path.Join (POSIX package) in three files: - pkg/config/setup/privateactionrunner.go — container path prefix joining - pkg/config/setup/privateactionrunner_test.go — test assertion using same join - pkg/privateactionrunner/bundles/remoteaction/rshell/run_command.go — resolveProcPath These are Linux container paths (/host/...) that must always use forward slashes regardless of the host OS. Co-authored-by: alexandre.yang <alexandre.yang@datadoghq.com>
AlexandreYang
added a commit
that referenced
this pull request
Mar 27, 2026
…ntainer-aware prefixing"" (#48462) Reverts #48460 Revert + this test fix: All tests pass. Here's a summary of the fix: Root cause: Both filepath.Join calls used OS path separators. On Windows, filepath.Join("/host", "/var/log") produces \host\var\log, breaking tests that expected Linux-style paths. Similarly, filepath.Join("/host", "/proc") produced \host\proc which didn't match the mock key /host/proc, causing resolveProcPath to fall back to /proc. Fix: Replaced filepath.Join with path.Join (POSIX package) in three files: - pkg/config/setup/privateactionrunner.go — container path prefix joining - pkg/config/setup/privateactionrunner_test.go — test assertion using same join - pkg/privateactionrunner/bundles/remoteaction/rshell/run_command.go — resolveProcPath These are Linux container paths (/host/...) that must always use forward slashes regardless of the host OS. Co-authored-by: alexandre.yang <alexandre.yang@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #48236
The original PR is causing several windows tests to fail.