[observer] Disable metrics eks option#49910
Merged
CelianR merged 5 commits intoq-branch-observerfrom Apr 27, 2026
Merged
Conversation
- Add compile-time interface guard for metricDropHandle - Warn when ingestMetricsEnabled=false so operators can diagnose silent metric drops - Fix t.Cleanup + sync.Once for safe goroutine shutdown in test (prevents leak on t.Fatal) - Add logReceived/profileReceived counters to countingHandle; assert forwarding in TestMetricDropHandle - Rename TestMetricDropHandleUnit → TestMetricDropHandle (drop redundant Unit suffix) - Rename dropHandle local var (was dropHandle, shadowing the type name) - Trim verbose multi-paragraph test doc comment to a single sentence - Fix run-on sentence in config.go observer.ingest_metrics.enabled comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds --disable-metrics-ingestion flag to the gensim submit task and threads it through the Pulumi run, agent-values template, and tests so log-only anomaly detection can be exercised without external metrics. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When recording and ingest_metrics.enabled=false are both active, recordingHandle calls ObserveMetricAndReportDrop on the wrapping metricDropHandle. Returning false caused the recorder to write Dropped=false, so testbench replays included metrics the live observer never ingested. Return true so the recorder correctly marks them dropped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds an option to disable metrics on eks task.
It also cleans the latest code for that.
Motivation
Describe how you validated your changes
Additional Notes